Skip to content

Update thread sanitizer CI to use a Python 3.15 image#243

Closed
ngoldbaum wants to merge 2 commits intopython-cffi:mainfrom
ngoldbaum:fix-tsan
Closed

Update thread sanitizer CI to use a Python 3.15 image#243
ngoldbaum wants to merge 2 commits intopython-cffi:mainfrom
ngoldbaum:fix-tsan

Conversation

@ngoldbaum
Copy link
Copy Markdown
Contributor

@ngoldbaum ngoldbaum commented Apr 21, 2026

I can't reproduce the TSan failures under 3.15. There have been a number of thread safety fixes to the standard library since 3.14, so in addition to fixing the issue we're hitting in CI, we can also completely remove the suppressions file as well.

Also adds test timeouts per the advice here.

Ping @kumaraditya303 since he originally set all this up last year.

Fixes #242.

@ngoldbaum ngoldbaum mentioned this pull request Apr 21, 2026
Copy link
Copy Markdown
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't reproduce the TSan failures under 3.15. There have been a number of thread safety fixes to the standard library since 3.14, so in addition to fixing the issue we're hitting in CI, we can also completely remove the suppressions file as well.

Yes, in main branch all of them are fixed.

This LGTM

@mattip
Copy link
Copy Markdown
Contributor

mattip commented Apr 21, 2026

I am a little uncomfortable using an alpha-release python as the ground truth for the TSAN builds. What does numpy do?

@ngoldbaum
Copy link
Copy Markdown
Contributor Author

What does numpy do?

NumPy uses Python 3.14, although I personally think it'd probably be fine to update those builds.

https://github.com/numpy/numpy/blob/388bd75829842d8230147f57eba5f86bb3ad6c3c/.github/workflows/compiler_sanitizers.yml#L90

I am a little uncomfortable using an alpha-release python as the ground truth for the TSAN builds.

Fair enough, let me see if I can add a suppression for the issue CI is currently hitting.

@ngoldbaum
Copy link
Copy Markdown
Contributor Author

let me see if I can add a suppression for the issue CI is currently hitting.

See #244.

@ngoldbaum ngoldbaum closed this Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TSan CI is flaky

3 participants