fix: skip widgets with empty or infinite rects in remove_rotation#4953
Open
thakoreh wants to merge 1 commit intopymupdf:mainfrom
Open
fix: skip widgets with empty or infinite rects in remove_rotation#4953thakoreh wants to merge 1 commit intopymupdf:mainfrom
thakoreh wants to merge 1 commit intopymupdf:mainfrom
Conversation
remove_rotation() calls widget.update() on every widget, but widgets
with empty or infinite rects (like invisible signature fields) cause
ValueError('bad rect') during validation.
Skip these widgets and also guard widget.update() with a try/except
for any remaining edge cases.
Fixes pymupdf#4950
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Comment on lines
+11919
to
+11922
| try: | ||
| widget.update() | ||
| except ValueError: | ||
| pass |
Collaborator
There was a problem hiding this comment.
Do we actually need this exception handling, now that we ignore empty or infinite rectangle r? I.e. what is meant by remaining edge cases?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4950
remove_rotation() iterates over all widgets and calls widget.update()
after transforming their rect. Widgets with empty or infinite rects
(like invisible signature fields with Rect(0, 0, 0, 0)) cause
ValueError('bad rect') during the internal validation in update().
This skips widgets with empty or infinite rects before the update
call, and wraps widget.update() in a try/except for any remaining
edge cases.