Implement persistent underline for top-level site section in left side navigation#1373
Draft
kennethyyoung wants to merge 9 commits intoprocessing:mainfrom
Draft
Implement persistent underline for top-level site section in left side navigation#1373kennethyyoung wants to merge 9 commits intoprocessing:mainfrom
kennethyyoung wants to merge 9 commits intoprocessing:mainfrom
Conversation
Organize and clarify main navigation link files and requirements.
Clarified the purpose of .current in MainNavLinks and added a note about underline styles.
…ng/p5.js-website into underline-navigation Merging code changes with brainstorm.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1303
Changes:
Implements a persistent underline for top-level navigation items (e.g., Reference, Examples, Tutorials). The underline remains active both on the top-level section page and while navigating through its sub-sections.
currentPath, derived frompathMinusLocal, inindex.astro.startsWith()to allow the underline to persist when the current path is a sub-section"current"toMainNavLinksto trigger the underline stylelinklabelstyle used inJumpToLinks.tsx. Updates to the underline style will change both the underline for top-level navigation and sub-section links.PR Checklist
npm run lintpassesCollaborative contribution from:
@kennethyyoung, @mikeng07, and @aaronalaman as part of the April 2026 CodeDay Microinternship.