Modernize and support functions without arguments#37
Open
0x80 wants to merge 7 commits intopolitics-rewired:mainfrom
Open
Modernize and support functions without arguments#370x80 wants to merge 7 commits intopolitics-rewired:mainfrom
0x80 wants to merge 7 commits intopolitics-rewired:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I started using this library in my projects, I ran into a few issues:
connect()on it. This seems to be a mistake because connect can only be called once, and therefore control should be left to the calling context I think.In addition
Yarn could be configured for v4 instead of v1, but I tried to not touch the lockfile. I did not expect to update other dependencies then, so we might as well configure it to use yarn v4 now...