Skip to content

Revert fix #5520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
staabm merged 1 commit into from
Apr 23, 2026
+0 −8
Merged

Revert fix #5520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/Type/Generic/TemplateBenevolentUnionType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
namespace PHPStan\Type\Generic;

use PHPStan\Type\BenevolentUnionType;
use PHPStan\Type\NeverType;
use PHPStan\Type\Type;

/** @api */
Expand Down Expand Up @@ -51,9 +50,6 @@ public function withTypes(array $types): self
public function filterTypes(callable $filterCb): Type
{
$result = parent::filterTypes($filterCb);
if ($result instanceof NeverType) {
return $result;
}
if (!$result instanceof TemplateType) {
return TemplateTypeFactory::create(
$this->getScope(),
Expand Down
4 changes: 0 additions & 4 deletions src/Type/Generic/TemplateUnionType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

namespace PHPStan\Type\Generic;

use PHPStan\Type\NeverType;
use PHPStan\Type\Type;
use PHPStan\Type\UnionType;

Expand Down Expand Up @@ -38,9 +37,6 @@ public function __construct(
public function filterTypes(callable $filterCb): Type
{
$result = parent::filterTypes($filterCb);
if ($result instanceof NeverType) {
return $result;
}
if (!$result instanceof TemplateType) {
return TemplateTypeFactory::create(
$this->getScope(),
Expand Down
Loading