Fix phpstan/phpstan#12871: Allow readonly property init in child classes on PHP 8.4+#5513
Open
predictor2718 wants to merge 1 commit intophpstan:2.1.xfrom
Open
Fix phpstan/phpstan#12871: Allow readonly property init in child classes on PHP 8.4+#5513predictor2718 wants to merge 1 commit intophpstan:2.1.xfrom
predictor2718 wants to merge 1 commit intophpstan:2.1.xfrom
Conversation
VincentLanglet
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since PHP 8.4,
readonlyproperties are implicitlyprotected(set), so a child class may initialize the parent's readonly property in its own constructor. PHPStan still reportedproperty.readOnlyAssignOutOfClassfor such assignments.Changes
src/Rules/Properties/ReadOnlyPropertyAssignRule.php: allow the "scope != declaring class" case whenPhpVersion::supportsAsymmetricVisibility()is true, the property is notprivate(set), and the scope is a subclass of the declaring class. The existing constructor check still applies in the subclass's scope.tests/PHPStan/Rules/Properties/ReadOnlyPropertyAssignRuleTest.php: injectPhpVersion, adjust existingtestRuleexpectations for PHP 8.4+ (subclass-constructor writes toprotected/public readonlyare no longer reported; subclass non-constructor write now reports "outside of the constructor" instead of "outside of its declaring class").testBug12871with data filedata/bug-12871.phpcovering the original snippet plusprivate(set)and non-constructor edge cases.Test
vendor/bin/phpunit tests/PHPStan/Rules/Properties/— 331 tests pass. Self-analysis[OK] No errors.Fixes phpstan/phpstan#12871