ext/phar: avoid redundant allocation by using zend_string for alias#21785
Open
arshidkv12 wants to merge 4 commits intophp:masterfrom
Open
ext/phar: avoid redundant allocation by using zend_string for alias#21785arshidkv12 wants to merge 4 commits intophp:masterfrom
arshidkv12 wants to merge 4 commits intophp:masterfrom
Conversation
iluuu1994
reviewed
Apr 17, 2026
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
No technical review performed.
| } | ||
|
|
||
| if (!actual_alias && zend_string_equals_literal(entry.filename, ".phar/alias.txt")) { | ||
| if (actual_alias == NULL && zend_string_equals_literal(entry.filename, ".phar/alias.txt")) { |
Member
There was a problem hiding this comment.
Please avoid changes like this. There are others in this PR.
| mydata->is_temporary_alias = 0; | ||
|
|
||
| if (NULL != (fd_ptr = zend_hash_str_find_ptr(&(PHAR_G(phar_alias_map)), actual_alias, mydata->alias_len))) { | ||
| if (NULL != (fd_ptr = zend_hash_str_find_ptr(&(PHAR_G(phar_alias_map)), ZSTR_VAL(actual_alias), ZSTR_LEN(actual_alias)))) { |
Member
|
@Girgias Would you like to review this? I saw you make some phar PRs, I don't know if that means you're interested in getting more familiar with it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.