fix: reboot threads on opcache reset and watcher#2364
Draft
AlliBalliBaba wants to merge 34 commits intomainfrom
Draft
fix: reboot threads on opcache reset and watcher#2364AlliBalliBaba wants to merge 34 commits intomainfrom
AlliBalliBaba wants to merge 34 commits intomainfrom
Conversation
# Conflicts: # caddy/caddy_test.go
Signed-off-by: Marc <m@pyc.ac>
AlliBalliBaba
changed the title
Contributor
Author
|
This PR is based on the changes in #2073. Instead of calling opcache sirextly, we just reset the whole php runtime. I haven't testes the additional overhead yet or the impact on file watching, but it might be a cleaner aolution, bypassing opcache race conditions entirely. |
Contributor
Author
|
When measuring with real-life projects, restart time slows down about 4x from ~12ms to ~48ms. Maybe that's not significant, maybe it's too much. Would be nice to also measure the difference on Mac. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #2073 that reboots all threads instead