chore(workflows): align issue label and preview gating#12385
chore(workflows): align issue label and preview gating#12385nicolethoen wants to merge 2 commits intopatternfly:mainfrom
Conversation
Replace the legacy issue workflow with the org-level PF team label caller, and gate PR preview deploys behind the reusable team-membership check. Made-with: Cursor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughRemoves the repository's Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview: https://pf-react-pr-12385.surge.sh A11y report: https://pf-react-pr-12385-a11y.surge.sh |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/label-pf-team-issue.yml (1)
7-9: Pin reusable workflows to full commit SHAs instead of@main.Using floating branch refs like
@mainallows behavior to change outside this repo and makes workflow runs harder to reproduce. GitHub's official documentation recommends pinning both reusable workflows and actions to full commit SHAs for stability and security; this mitigates supply chain attacks and ensures consistent, reproducible behavior across runs.This applies to:
.github/workflows/label-pf-team-issue.ymlline 8 (add-pf-team-label-workflow).github/workflows/documentation.ymlline 21 (check-team-membership)Suggested change
- uses: patternfly/.github/.github/workflows/add-pf-team-label-workflow.yml@main + uses: patternfly/.github/.github/workflows/add-pf-team-label-workflow.yml@<full-commit-sha>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/label-pf-team-issue.yml around lines 7 - 9, Replace floating branch refs with full commit SHAs for the reusable workflow usages: update the label workflow reference "patternfly/.github/.github/workflows/add-pf-team-label-workflow.yml@main" in label-pf-team-issue.yml to the repository’s exact commit SHA (pin to a specific commit) and likewise update the "check-team-membership" reusable workflow reference in documentation.yml to its full commit SHA; ensure you use the exact commit SHAs (not tags or branch names) so both reusable workflow calls are pinned for reproducible runs.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/documentation.yml:
- Around line 15-20: The check-permissions job is skipped for workflow_call
events causing dependent jobs like deploy to be skipped; update the
check-permissions job's if condition to include github.event_name ==
'workflow_call' (i.e., extend the condition in check-permissions to also run
when github.event_name == 'workflow_call') so that deploy and other dependent
jobs (referenced by needs: [check-permissions], e.g., deploy) won't be skipped
when invoked via the reusable workflow.
---
Nitpick comments:
In @.github/workflows/label-pf-team-issue.yml:
- Around line 7-9: Replace floating branch refs with full commit SHAs for the
reusable workflow usages: update the label workflow reference
"patternfly/.github/.github/workflows/add-pf-team-label-workflow.yml@main" in
label-pf-team-issue.yml to the repository’s exact commit SHA (pin to a specific
commit) and likewise update the "check-team-membership" reusable workflow
reference in documentation.yml to its full commit SHA; ensure you use the exact
commit SHAs (not tags or branch names) so both reusable workflow calls are
pinned for reproducible runs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f1f6d4ee-e011-4181-9171-635b8801bc0f
📒 Files selected for processing (3)
.github/workflows/add-new-issues-to-project.yml.github/workflows/documentation.yml.github/workflows/label-pf-team-issue.yml
💤 Files with no reviewable changes (1)
- .github/workflows/add-new-issues-to-project.yml
Remove the caller-level condition on check-permissions so workflow_call runs are not skipped through dependency status. Made-with: Cursor
Replace the legacy issue workflow with the org-level PF team label caller, and gate PR preview deploys behind the reusable team-membership check.
Made-with: Cursor
Summary by CodeRabbit