Updated all usage of AngleDoubleLeftIcon to RhUiDoubleCaretLeftIcon#12381
Updated all usage of AngleDoubleLeftIcon to RhUiDoubleCaretLeftIcon#12381tlabaj wants to merge 1 commit intopatternfly:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (19)
WalkthroughThis PR systematically replaces the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview: https://pf-react-pr-12381.surge.sh A11y report: https://pf-react-pr-12381-a11y.surge.sh |
nicolethoen
left a comment
There was a problem hiding this comment.
Looks good - snapshots might need to be updated again
thatblindgeye
left a comment
There was a problem hiding this comment.
Can we check if Cor
@thatblindgeye Your message got cut off. What do we need to check? |
|
lol whoops. Was gonna ask if we can check if Core has an issue to make the same update but then I remembered I had made an issue during my initial single caret updates there. |
bekah-stephens
left a comment
There was a problem hiding this comment.
I'm having issues pulling up the preview link, so I can't double check. I believe these should be using the micron version of the double caret -- @andrew-ronaldson is this true? I'm assuming most places where an icon has a micron version, we want to use that
What: towards #12244
Summary
Replaces all usages of
AngleDoubleLeftIconwithRhUiDoubleCaretLeftIcon(import path:@patternfly/react-icons/dist/esm/icons/rh-ui-double-caret-left-icon) across production code, examples, and demo apps for consistency with the Red Hat UI icon set.Changes
PaginationNavigation“first page” control now usesRhUiDoubleCaretLeftIcon.DualListSelectorand all non–code-connect examples (basic, tooltips, search, tree, complex actions, composable, drag-and-drop variants) plus related.mddocs.demo-app-tsDualListSelector demo screens updated to match.Pagination,PaginationNavigation, deprecatedDualListSelector).Summary by CodeRabbit