feat(Drawer): Added support for glass#12305
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview: https://pf-react-pr-12305.surge.sh A11y report: https://pf-react-pr-12305-a11y.surge.sh |
thatblindgeye
requested review from
kmcfaul,
mcoker and
thatblindgeye
and removed request for
mcoker
|
This PR is waiting for patternfly/patternfly#8267 to be fixed. |
|
@tlabaj just closed patternfly/patternfly#8267, it was done in patternfly/patternfly#8266 which should be in core |
|
@mcoker The modifiers do not seem to be working as expected.
|
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
Couple of docs updates but lgtm!
| isResizable?: boolean; | ||
| /** @beta Flag indicating that the drawer panel should disable glass styles. This prop is intended to work with isPill drawers. */ | ||
| hasNoGlass?: boolean; | ||
| /** @beta Flag indicating that the drawer panel should use glass styles. */ |
There was a problem hiding this comment.
Mention applies glass styles in glass theme
| /** @beta Flag indicating that the drawer panel should use plain styles. */ | ||
| isPlain?: boolean; | ||
| /** @beta Flag indicating that plain styles should be disabled when glass styles are used. */ | ||
| isNoPlainOnGlass?: boolean; |
There was a problem hiding this comment.
mention these apply to inline and static drawers.
5 participants
What: Closes #12273
Changes to drawer:
Changes to DrawerPanelContent:
isGlass(@beta, default false) — appliespf-m-glassisPlain(@beta, default false) — appliespf-m-plainisNoPlainOnGlass(@beta, default false) — appliespf-m-no-plainDrawerColorVariant.noBackgroundmarked @deprecated; migrate to isPlain for plain styling (still applies pf-m-no-background so existing snapshots and consumers stay stable).isGlass,isPlain,isNoPlainOnGlass, and clarified test name for deprecated no-backgroundChanges for DrawerSection:
added
isPlain(@beta, default false) — appliespf-m-plainDrawerColorVariant.noBackgroundmarked @deprecated; migrate to isPlain for plain styling (still appliespf-m-no-backgroundso existing snapshots and consumers stay stable).Added new test for
isPlainUpdated PrimaryDetailContentPadding demo: DrawerPanelContent uses i
sPlain; removed invalid DrawerContentcolorVariant="no-background"(not supported on DrawerContent)