Skip to content

[TECHNICAL] SBOM changes to be pushed in an specific branch with signed commits#4837

Open
jesmrec wants to merge 3 commits intomasterfrom
technical/adapt_sbom_workflow_signed_commits
Open

[TECHNICAL] SBOM changes to be pushed in an specific branch with signed commits#4837
jesmrec wants to merge 3 commits intomasterfrom
technical/adapt_sbom_workflow_signed_commits

Conversation

@jesmrec
Copy link
Copy Markdown
Contributor

@jesmrec jesmrec commented Apr 27, 2026

New logic of the workflow:

  • After merging a PR into master, the workflow is triggered
  • cycloneDx generates an SBOM over the new HEAD of master
  • Fetch the existing sbom file in the chore/sbom-update branch, if the branch exists. If not, get the origin/master one. The idea is getting the newest version to compare with
  • Both sbom files (the one generated in the workflow and the existing one to compare) are normalized and sorted to be compared using jq, in order to know if there are changes or not.
    • If there are changes -> create/update chore/sbom-update
    • If there are no changes -> stop

  • Added a manual dispatch in case dependencies are updated inside of a release branch, with target branch as parameter and master as default
  • Removed concurrency policy. Every PR must trigger the workflow to check dependencies.
  • Added an step to the release template to merge the sbom branch before creating release branch

Related Issues

App:

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@jesmrec jesmrec self-assigned this Apr 27, 2026
@jesmrec jesmrec force-pushed the technical/adapt_sbom_workflow_signed_commits branch 3 times, most recently from a00da5b to be8c3e2 Compare April 27, 2026 11:18
@jesmrec jesmrec marked this pull request as ready for review April 27, 2026 12:28
@jesmrec
Copy link
Copy Markdown
Contributor Author

jesmrec commented Apr 28, 2026

Moving to "In progress" again to inspect an issue before reviewing @joragua @DeepDiver1975

@jesmrec jesmrec force-pushed the technical/adapt_sbom_workflow_signed_commits branch from be8c3e2 to 4d0dcb2 Compare April 28, 2026 12:52
@jesmrec jesmrec force-pushed the technical/adapt_sbom_workflow_signed_commits branch from 4d0dcb2 to 531a27d Compare April 28, 2026 13:05
@jesmrec jesmrec added this to the 4.8 - Current milestone Apr 28, 2026
@jesmrec
Copy link
Copy Markdown
Contributor Author

jesmrec commented Apr 28, 2026

Ready for review again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant