stackrox: add ocp-vm-scanning-e2e-tests job (testing)#77856
stackrox: add ocp-vm-scanning-e2e-tests job (testing)#77856vikin91 wants to merge 3 commits intoopenshift:mainfrom
Conversation
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
|
Skipping CI for Draft Pull Request. |
|
/hold |
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 17 minutes and 58 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughA new CI/operator configuration YAML file is added for the stackrox project that defines a test execution pipeline for OCP 4.21, specifying base images, resource requests, environment variables pinned to OCP version 4.21, workflow assignment, optional test marking, and a 5-hour timeout. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 10✅ Passed checks (10 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vikin91 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pj-rehearse-max |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
ci-operator/config/stackrox/stackrox/stackrox-stackrox-piotr-ROX-29577-VM4VM-e2e-tests__ocp-4-21.yaml (1)
23-23: Track removal ofoptional: truebefore promoting to master config.For temporary branch validation this is fine, but carrying
optional: trueintostackrox-stackrox-master__ocp-4-21.yamlwould reduce signal by not gating failures.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/config/stackrox/stackrox/stackrox-stackrox-piotr-ROX-29577-VM4VM-e2e-tests__ocp-4-21.yaml` at line 23, This change temporarily sets the YAML flag "optional: true" which must not be carried into the master config; before promoting to master, remove the "optional: true" entry from the corresponding master config (stackrox-stackrox-master__ocp-4-21.yaml) so failures are gated, and add a short TODO/PR note or create a follow-up task referencing this branch so the removal is tracked and verified prior to merge.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@ci-operator/config/stackrox/stackrox/stackrox-stackrox-piotr-ROX-29577-VM4VM-e2e-tests__ocp-4-21.yaml`:
- Line 29: The job timeout is currently set to 5h0m0s but the step
"stackrox-stackrox-e2e-test" requires 7h0m0s; update the timeout value from
5h0m0s to at least 7h0m0s (e.g., timeout: 7h0m0s) in this job's YAML so the job
does not terminate before the step completes.
---
Nitpick comments:
In
`@ci-operator/config/stackrox/stackrox/stackrox-stackrox-piotr-ROX-29577-VM4VM-e2e-tests__ocp-4-21.yaml`:
- Line 23: This change temporarily sets the YAML flag "optional: true" which
must not be carried into the master config; before promoting to master, remove
the "optional: true" entry from the corresponding master config
(stackrox-stackrox-master__ocp-4-21.yaml) so failures are gated, and add a short
TODO/PR note or create a follow-up task referencing this branch so the removal
is tracked and verified prior to merge.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: d1ea32fd-086b-4065-bb32-92e188ae0a23
📒 Files selected for processing (1)
ci-operator/config/stackrox/stackrox/stackrox-stackrox-piotr-ROX-29577-VM4VM-e2e-tests__ocp-4-21.yaml
|
/test all |
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
|
/test all |
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
|
/test all |
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@vikin91: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Adds CI config for the
ocp-vm-scanning-e2e-testsjob targeting thepiotr/ROX-29577-VM4VM-e2e-testsfeature branch instackrox/stackrox.stackrox-automation-flavors-ocp-4-e2eworkflow with OCP 4.21 candidateTest plan
stackrox-stackrox-master__ocp-4-21.yamlSummary by CodeRabbit