Skip to content

chore(prow): add opendatahub-io/model-registry-operator#77849

Open
pboyd wants to merge 1 commit intoopenshift:mainfrom
pboyd:prow-model-registry-operator
Open

chore(prow): add opendatahub-io/model-registry-operator#77849
pboyd wants to merge 1 commit intoopenshift:mainfrom
pboyd:prow-model-registry-operator

Conversation

@pboyd
Copy link
Copy Markdown

@pboyd pboyd commented Apr 15, 2026

Add opendatahub-io/model-registry-operator to the prow config.

Summary by CodeRabbit

Chores

  • Configured governance and code review policies for the model-registry-operator repository, including approval requirements and reviewer assignments.
  • Established CI/CD automation settings with merge workflow validation, automated plugins for pull request processing, and merge conflict handling.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 15, 2026

Walkthrough

Three configuration files are added for the model-registry-operator repository under OpenDataHub's Prow setup. These files define repository ownership, plugin configuration settings, and merge behavior rules. Total addition: 120 lines across OWNERS, plugin configuration, and tide configuration.

Changes

Cohort / File(s) Summary
Prow Configuration for model-registry-operator
core-services/prow/02_config/opendatahub-io/model-registry-operator/OWNERS, core-services/prow/02_config/opendatahub-io/model-registry-operator/_pluginconfig.yaml, core-services/prow/02_config/opendatahub-io/model-registry-operator/_prowconfig.yaml
New OWNERS file defining approvers, reviewers, and emeritus approvers. Plugin configuration enabling external integrations (refresh, cherrypick, needs-rebase, jira-lifecycle, etc.) and internal Prow plugins with LGTM handling. Tide configuration setting squash merge method and defining required labels (approved, lgtm) and blocking labels for merge validation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding opendatahub-io/model-registry-operator to prow configuration, which is precisely what the changeset accomplishes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed This PR adds Prow configuration files but contains no Ginkgo test code or test titles, making it not applicable to the test naming convention check.
Test Structure And Quality ✅ Passed This custom check is not applicable to the provided pull request. The check assesses Ginkgo test code quality, but this PR only adds Prow configuration files with no Ginkgo test files.
Microshift Test Compatibility ✅ Passed This PR adds only Prow configuration files for the opendatahub-io/model-registry-operator repository. No new Ginkgo e2e tests are added, so the custom check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR adds only Prow CI/CD configuration files, not Ginkgo e2e tests, so the custom check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed Pull request adds only Prow CI/CD configuration files (OWNERS, _pluginconfig.yaml, _prowconfig.yaml) with no deployment manifests, operator code, or Kubernetes pod scheduling constraints.
Ote Binary Stdout Contract ✅ Passed PR adds only YAML configuration files and metadata for Prow CI/CD; no executable process-level code that could violate OTE Binary Stdout Contract.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR contains no Ginkgo e2e tests; only Prow CI/CD configuration changes present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 15, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 15, 2026

Hi @pboyd. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pboyd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2026
@openshift-ci openshift-ci bot requested review from bear-redhat and psalajova April 15, 2026 14:30
@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Apr 15, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 15, 2026

The OWNERS file contains untrusted users, which makes it INVALID. The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the openshift org. You can then trigger verification by writing /verify-owners in a comment.

  • pboyd
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • core-services/prow/02_config/opendatahub-io/model-registry-operator/OWNERS

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
core-services/prow/02_config/opendatahub-io/model-registry-operator/_pluginconfig.yaml (1)

1-5: Consider adding a commandHelpLink for better documentation.

The commandHelpLink is currently empty. Consider adding a URL pointing to documentation about the approval process to help contributors understand the workflow.

📝 Optional improvement
 approve:
-- commandHelpLink: ""
+  commandHelpLink: "https://prow.ci.openshift.org/command-help"
   repos:
   - opendatahub-io/model-registry-operator
   require_self_approval: false
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@core-services/prow/02_config/opendatahub-io/model-registry-operator/_pluginconfig.yaml`
around lines 1 - 5, The approve block currently has an empty commandHelpLink;
update the approve -> commandHelpLink string to a relevant URL pointing to the
project's approval/PR workflow docs (for example the contributor or PR approval
guide) so contributors to opendatahub-io/model-registry-operator can find help;
locate the approve section and set commandHelpLink to the chosen documentation
URL (ensure it is a valid HTTP/HTTPS string).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In
`@core-services/prow/02_config/opendatahub-io/model-registry-operator/_pluginconfig.yaml`:
- Around line 1-5: The approve block currently has an empty commandHelpLink;
update the approve -> commandHelpLink string to a relevant URL pointing to the
project's approval/PR workflow docs (for example the contributor or PR approval
guide) so contributors to opendatahub-io/model-registry-operator can find help;
locate the approve section and set commandHelpLink to the chosen documentation
URL (ensure it is a valid HTTP/HTTPS string).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f9e04925-a583-44a1-a604-d2ac09d5434a

📥 Commits

Reviewing files that changed from the base of the PR and between 67862bf and cbdc970.

📒 Files selected for processing (3)
  • core-services/prow/02_config/opendatahub-io/model-registry-operator/OWNERS
  • core-services/prow/02_config/opendatahub-io/model-registry-operator/_pluginconfig.yaml
  • core-services/prow/02_config/opendatahub-io/model-registry-operator/_prowconfig.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant