Conversation
Swap to perf-scale (non-qe) for 4.22 jobs (5.0 too for ovnk). Signed-off-by: Joe Talerico aka rook <joe.talerico@gmail.com>
WalkthroughUpdated AWS cluster configuration across multiple CI operator job definitions, changing cluster profile from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 10✅ Passed checks (10 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jtaleric The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-4.22-nightly-x86.yaml (1)
22-37:⚠️ Potential issue | 🟠 MajorIncomplete 4.22 migration leaves mixed cluster profiles/domains in the same variant.
The updated jobs switched correctly, but several other 4.22 jobs in this same file still use the old pair (
aws-perfscale-qe+qe.devcluster.openshift.com) at Line 142/144, Line 155/157, Line 166/169, Line 197/199, and Line 211/213. This makes the 4.22 profile swap partial.🔧 Suggested follow-up patch for remaining 4.22 entries in this file
- cluster_profile: aws-perfscale-qe + cluster_profile: aws-perfscale env: - BASE_DOMAIN: qe.devcluster.openshift.com + BASE_DOMAIN: perfscale.devcluster.openshift.comApply that pair to:
as: conc-builds-3nodesas: compact-cp-3nodesas: router-perf-24nodesas: control-plane-3nodesas: node-density-cni-3nodesAlso applies to: 111-129, 274-295
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-4.22-nightly-x86.yaml` around lines 22 - 37, Several 4.22 job entries in this file still use the old cluster_profile/BASE_DOMAIN pair (aws-perfscale-qe + qe.devcluster.openshift.com) causing a partial migration; update each listed job to use the new pair (cluster_profile: aws-perfscale and BASE_DOMAIN: perfscale.devcluster.openshift.com). Locate the job blocks with as: conc-builds-3nodes, as: compact-cp-3nodes, as: router-perf-24nodes, as: control-plane-3nodes, and as: node-density-cni-3nodes (and the other occurrences around the ranges noted) and replace cluster_profile and BASE_DOMAIN values to the new ones so all 4.22 variants consistently use aws-perfscale and perfscale.devcluster.openshift.com. Ensure the env keys (ADDITIONAL_WORKER_NODES/ZONES_COUNT if present) remain unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In
`@ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-4.22-nightly-x86.yaml`:
- Around line 22-37: Several 4.22 job entries in this file still use the old
cluster_profile/BASE_DOMAIN pair (aws-perfscale-qe +
qe.devcluster.openshift.com) causing a partial migration; update each listed job
to use the new pair (cluster_profile: aws-perfscale and BASE_DOMAIN:
perfscale.devcluster.openshift.com). Locate the job blocks with as:
conc-builds-3nodes, as: compact-cp-3nodes, as: router-perf-24nodes, as:
control-plane-3nodes, and as: node-density-cni-3nodes (and the other occurrences
around the ranges noted) and replace cluster_profile and BASE_DOMAIN values to
the new ones so all 4.22 variants consistently use aws-perfscale and
perfscale.devcluster.openshift.com. Ensure the env keys
(ADDITIONAL_WORKER_NODES/ZONES_COUNT if present) remain unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 5274ac74-3aa4-46bc-8a0d-d8741afacc89
📒 Files selected for processing (6)
ci-operator/config/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main__aws-4.22-nightly-x86.yamlci-operator/config/openshift/ovn-kubernetes/openshift-ovn-kubernetes-release-4.22.yamlci-operator/config/openshift/ovn-kubernetes/openshift-ovn-kubernetes-release-5.0.yamlci-operator/jobs/openshift-eng/ocp-qe-perfscale-ci/openshift-eng-ocp-qe-perfscale-ci-main-periodics.yamlci-operator/jobs/openshift/ovn-kubernetes/openshift-ovn-kubernetes-release-4.22-presubmits.yamlci-operator/jobs/openshift/ovn-kubernetes/openshift-ovn-kubernetes-release-5.0-presubmits.yaml
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
@jtaleric: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Swap to perf-scale (non-qe) for 4.22 jobs (5.0 too for ovnk).
Summary by CodeRabbit