Skip to content

OCPBUGS-83705: bump google.golang.org/grpc to v1.79.3#6522

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
pmtk:grpc-cve-main
Apr 20, 2026
Merged

OCPBUGS-83705: bump google.golang.org/grpc to v1.79.3#6522
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
pmtk:grpc-cve-main

Conversation

@pmtk
Copy link
Copy Markdown
Member

@pmtk pmtk commented Apr 17, 2026

Summary by CodeRabbit

  • Chores
    • Updated gRPC dependency to the latest patch version for improved stability and performance.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 17, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@pmtk: This pull request references Jira Issue OCPBUGS-83705, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from agullon and jerpeter1 April 17, 2026 12:49
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: da73211e-d772-44e1-99c2-262422ed346e

📥 Commits

Reviewing files that changed from the base of the PR and between bbad4d6 and a325183.

⛔ Files ignored due to path filters (10)
  • etcd/go.sum is excluded by !**/*.sum
  • etcd/vendor/google.golang.org/grpc/internal/envconfig/envconfig.go is excluded by !**/vendor/**
  • etcd/vendor/google.golang.org/grpc/server.go is excluded by !**/vendor/**
  • etcd/vendor/google.golang.org/grpc/version.go is excluded by !**/vendor/**
  • etcd/vendor/modules.txt is excluded by !**/vendor/**
  • go.sum is excluded by !**/*.sum
  • vendor/google.golang.org/grpc/internal/envconfig/envconfig.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/grpc/server.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/grpc/version.go is excluded by !**/vendor/**, !vendor/**
  • vendor/modules.txt is excluded by !**/vendor/**, !vendor/**
📒 Files selected for processing (2)
  • etcd/go.mod
  • go.mod

Walkthrough

The PR updates the google.golang.org/grpc indirect dependency from v1.79.2 to v1.79.3 across go.mod files, applying a patch version bump to the resolved gRPC module version.

Changes

Cohort / File(s) Summary
gRPC Dependency Update
etcd/go.mod, go.mod
Updated google.golang.org/grpc indirect dependency from v1.79.2 to v1.79.3.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: a version bump of google.golang.org/grpc from v1.79.2 to v1.79.3 across both go.mod files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed PR only modifies configuration, documentation, and go.mod files for grpc dependency bump. No Ginkgo test files or test code were changed.
Test Structure And Quality ✅ Passed PR contains only dependency version updates in go.mod files with no Ginkgo test code or test file modifications, making this check not applicable.
Microshift Test Compatibility ✅ Passed Custom check for MicroShift test compatibility does not apply as PR only updates gRPC dependency versions without adding new Ginkgo e2e tests.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR updates google.golang.org/grpc dependency in go.mod files. No new Ginkgo e2e tests added, so SNO Test Compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR only updates gRPC library dependency version in go.mod files. No deployment manifests, operator code, or controllers are modified, so topology-aware scheduling check is not applicable.
Ote Binary Stdout Contract ✅ Passed PR modifies only go.mod and go.sum files with no Go source code changes, making stdout contract violations impossible.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Pull request only updates google.golang.org/grpc dependency version; no new Ginkgo e2e tests added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

level=error msg="Running error: context loading failed: failed to load packages: failed to load packages: failed to load with go/packages: err: exit status 1: stderr: go: inconsistent vendoring in :\n\tgithub.com/apparentlymart/go-cidr@v1.1.0: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\tgithub.com/coreos/go-systemd@v0.0.0-20190321100706-95778dfbb74e: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\tgithub.com/google/go-cmp@v0.7.0: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\tgithub.com/miekg/dns@v1.1.63: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\tgithub.com/openshift/api@v0.0.0-20260309155933-45fd88d185dd: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\tgithub.com/openshift/build-machinery-go@v0.0.0-20251023084048-5d77c1a5e5af: is explicitly required in go.mod, but not marked as explicit

... [truncated 29518 characters] ...

belet: is replaced in go.mod, but not marked as replaced in vendor/modules.txt\n\tk8s.io/metrics: is replaced in go.mod, but not marked as replaced in vendor/modules.txt\n\tk8s.io/mount-utils: is replaced in go.mod, but not marked as replaced in vendor/modules.txt\n\tk8s.io/pod-security-admission: is replaced in go.mod, but not marked as replaced in vendor/modules.txt\n\tk8s.io/sample-apiserver: is replaced in go.mod, but not marked as replaced in vendor/modules.txt\n\tk8s.io/sample-cli-plugin: is replaced in go.mod, but not marked as replaced in vendor/modules.txt\n\tk8s.io/sample-controller: is replaced in go.mod, but not marked as replaced in vendor/modules.txt\n\n\tTo ignore the vendor directory, use -mod=readonly or -mod=mod.\n\tTo sync the vendor directory, run:\n\t\tgo mod vendor\n"


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link
Copy Markdown

@pmtk: This pull request references Jira Issue OCPBUGS-83705, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

Summary by CodeRabbit

  • Chores
  • Updated gRPC dependency to the latest patch version for improved stability and performance.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Apr 20, 2026

/test test-rebase

@pmtk
Copy link
Copy Markdown
Member Author

pmtk commented Apr 20, 2026

/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 20, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@pmtk: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pacevedom
Copy link
Copy Markdown
Contributor

/retest

Copy link
Copy Markdown
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9264bfd and 2 for PR HEAD a325183 in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 20, 2026

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d910461 into openshift:main Apr 20, 2026
16 checks passed
@openshift-ci-robot
Copy link
Copy Markdown

@pmtk: Jira Issue OCPBUGS-83705: All pull requests linked via external trackers have merged:

All linked pull requests have the verified tag. Jira Issue OCPBUGS-83705 has been moved to the VERIFIED state.

Details

In response to this:

Summary by CodeRabbit

  • Chores
  • Updated gRPC dependency to the latest patch version for improved stability and performance.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants