Avoid empty label values for HTTP metrics#893
Open
simonpasquier wants to merge 1 commit intoobservatorium:mainfrom
Open
Avoid empty label values for HTTP metrics#893simonpasquier wants to merge 1 commit intoobservatorium:mainfrom
simonpasquier wants to merge 1 commit intoobservatorium:mainfrom
Conversation
This commit prevents the initialization of HTTP metrics with empty values for the `code`, `method` and `tenant` labels. These metrics were set to zero but never incremented. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Contributor
Author
Contributor
|
@simonpasquier just to add context, these change was added in #547 and IIUC it was to provide a solution to SLO alerts that were being generated by https://github.com/pyrra-dev/pyrra in low traffic environments. Just to clarify, I am not against the change in principle, just wanted to shine some light on it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit prevents the initialization of HTTP metrics with empty values for the
code,methodandtenantlabels. These metrics were set to zero but never incremented.