lib: use js-only implementation of isDataView()#62780
Open
Renegade334 wants to merge 2 commits intonodejs:mainfrom
Open
lib: use js-only implementation of isDataView()#62780Renegade334 wants to merge 2 commits intonodejs:mainfrom
isDataView()#62780Renegade334 wants to merge 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
lpinca
approved these changes
Apr 16, 2026
addaleax
approved these changes
Apr 16, 2026
Collaborator
ljharb
approved these changes
Apr 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62780 +/- ##
==========================================
- Coverage 91.54% 89.67% -1.88%
==========================================
Files 356 706 +350
Lines 149604 218196 +68592
Branches 23392 41753 +18361
==========================================
+ Hits 136961 195667 +58706
- Misses 12380 14464 +2084
- Partials 263 8065 +7802
🚀 New features to boost your workflow:
|
meixg
approved these changes
Apr 17, 2026
watilde
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already implement the TypedArray type check methods in the JS layer, as it's more performant to do it this way than to call into the embedder.
We can do the same with DataView – even though it potentially requires two JS calls, it's still more performant than using the V8 API, even when invoking the fast callback in a benchmarking scenario.