Skip to content

src: use context-free V8 message column getters #62778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Apr 18, 2026
+4 −4
Merged

src: use context-free V8 message column getters #62778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/inspector_agent.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,7 +677,7 @@ class NodeInspectorClient : public V8InspectorClient {
ToInspectorString(isolate, message->Get())->string(),
ToInspectorString(isolate, message->GetScriptResourceName())->string(),
message->GetLineNumber(context).FromMaybe(0),
message->GetStartColumn(context).FromMaybe(0),
message->GetStartColumn(),
client_->createStackTrace(stack_trace),
script_id);
}
Expand Down
6 changes: 3 additions & 3 deletions src/node_errors.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ static std::string GetSourceMapErrorSource(Isolate* isolate,
// the source texts.
Local<Value> script_resource_name = message->GetScriptResourceName();
int linenum = message->GetLineNumber(context).FromJust();
int columnum = message->GetStartColumn(context).FromJust();
int columnum = message->GetStartColumn();

Local<Value> argv[] = {script_resource_name,
v8::Int32::New(isolate, linenum),
Expand Down Expand Up @@ -148,8 +148,8 @@ static std::string GetErrorSource(Isolate* isolate,
int script_start = (linenum - origin.LineOffset()) == 1
? origin.ColumnOffset()
: 0;
int start = message->GetStartColumn(context).FromMaybe(0);
int end = message->GetEndColumn(context).FromMaybe(0);
int start = message->GetStartColumn();
int end = message->GetEndColumn();
if (start >= script_start) {
CHECK_GE(end, start);
start -= script_start;
Expand Down
Loading