tools: exclude @node-core/doc-kit from dependabot cooldown#62775
Open
kxxt wants to merge 1 commit intonodejs:mainfrom
Open
tools: exclude @node-core/doc-kit from dependabot cooldown#62775kxxt wants to merge 1 commit intonodejs:mainfrom
kxxt wants to merge 1 commit intonodejs:mainfrom
Conversation
nodejs-github-bot
added
the
meta
`@node-core/doc-kit` is an internal package maintained within the nodejs organization, which is unlikely to be a direct source of supply-chain attack. The cooldown only slow down the propagation of new improvements from doc-kit to Node.js repo and causes surprises. The cooldown should be configured in the `doc-kit` repository instead. Currently there is a 3-day cooldown. Maybe we need to increase that to match the 5-day cooldown used in this repository. This patch excludes `@node-core/doc-kit` from the cooldown. Note that `@node-core/doc-kit` is the only dependency in `tools/doc`. But to be future proof, I did't remove the cooldown directly.
ovflowd
approved these changes
Apr 16, 2026
ovflowd
added
fast-track
Contributor
|
Fast-track has been requested by @ovflowd. Please 👍 to approve. |
MikeMcC399
reviewed
Apr 16, 2026
Comment on lines
+21
to
+22
| exclude: | ||
| - '@node-core/doc-kit' |
Contributor
There was a problem hiding this comment.
The exception looks to be in the wrong place.
I believe it would need to go under
- package-ecosystem: npm
directory: /tools/doc
not under
- package-ecosystem: npm
directory: /tools/eslint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@node-core/doc-kitis an internal package maintained within the nodejs organization, which is unlikely to be a direct source of supply-chain attack. The cooldown only slow down the propagation of new improvements from doc-kit to Node.js repo and causes surprises.The cooldown should be configured in the
doc-kitrepository instead. Currently there is a 3-day cooldown. Maybe we need to increase that to match the 5-day cooldown used in this repository.This patch excludes
@node-core/doc-kitfrom the cooldown.Note that
@node-core/doc-kitis the only dependency intools/doc.But to be future proof, I did't remove the cooldown directly.
CC @nodejs/security-wg @nodejs/web-infra