fix(legacy-html): prevent scroll jump when opening header pickers#773
Open
Sahilshrma31 wants to merge 1 commit intonodejs:mainfrom
Open
fix(legacy-html): prevent scroll jump when opening header pickers#773Sahilshrma31 wants to merge 1 commit intonodejs:mainfrom
Sahilshrma31 wants to merge 1 commit intonodejs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Adds a null check and a Reviewed by Cursor Bugbot for commit d6a4bff. Bugbot is set up for automated code reviews on this repo. Configure here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an unintended page scroll jump when opening sticky header picker dropdowns in legacy HTML docs.
Validation
I reproduced and verified on a generated legacy HTML page (out/fs.html) and in browser behavior matching the reported scenario.
Reproduction steps
Open an API docs page.
Scroll to the middle of the page.
Open sticky header pickers (Table of contents, Index, Other versions, Options).
Before
Screen.Recording.2026-04-15.at.11.01.24.PM.mov
Opening a picker causes the page to jump upward unexpectedly.
After
Screen.Recording.2026-04-15.at.11.02.03.PM.mov
Opening a picker no longer changes scroll position; only the dropdown opens.
Related Issues
Fixes #764
Check List
node --run testand all tests passed.node --run format&node --run lint.