Skip to content

fix(files_sharing): prevent double-escaping of display names in sharing UI#59660

Open
predictor2718 wants to merge 2 commits intonextcloud:masterfrom
predictor2718:fix/sharing-display-name-double-escape
Open

fix(files_sharing): prevent double-escaping of display names in sharing UI#59660
predictor2718 wants to merge 2 commits intonextcloud:masterfrom
predictor2718:fix/sharing-display-name-double-escape

Conversation

@predictor2718
Copy link
Copy Markdown

@predictor2718 predictor2718 commented Apr 15, 2026

Summary

  • Display names containing & were shown as & in sharing tooltips and labels because t() escapes HTML by default and Vue escapes again on render
  • Added { escape: false } to t() calls in sharingStatusAction.ts, SharingEntry.vue, and SharingEntryInherited.vue, following the existing pattern in SharingEntryLink.vue and SharedWithMe.js
  • Added unit tests for sharingStatusAction title function to prevent regression

Before Fix

before-bug-visible-tooltip

After Fix

after-fix-tooltip

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@predictor2718 predictor2718 requested a review from a team as a code owner April 15, 2026 20:41
@predictor2718 predictor2718 requested review from nfebe, skjnldsv and sorbaugh and removed request for a team April 15, 2026 20:41
@CarlSchwan CarlSchwan requested a review from susnux April 20, 2026 11:39
@predictor2718 predictor2718 force-pushed the fix/sharing-display-name-double-escape branch 2 times, most recently from c4a8ae5 to 63c07d9 Compare April 21, 2026 15:12
@DorraJaouad DorraJaouad requested review from a team and provokateurin as code owners April 23, 2026 09:41
@DorraJaouad DorraJaouad requested review from salmart-dev and removed request for a team April 23, 2026 09:41
@github-actions
Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@predictor2718 predictor2718 force-pushed the fix/sharing-display-name-double-escape branch from 63c07d9 to d25f992 Compare May 1, 2026 08:34
…ng UI

Signed-off-by: Nicolai Ehrhardt <245527909+predictor2718@users.noreply.github.com>
Signed-off-by: Nicolai Ehrhardt <245527909+predictor2718@users.noreply.github.com>
@predictor2718 predictor2718 force-pushed the fix/sharing-display-name-double-escape branch from d25f992 to 0a69409 Compare May 1, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Avatar hover description in Files shows "&amp;" instead of "&"

1 participant