fix: use proper index when deleting mounts#59650
Merged
joshtrichards merged 1 commit intomasterfrom Apr 23, 2026
Merged
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
requested review from
Altahrim,
ArtificialOwl,
leftybournes and
sorbaugh
and removed request for
a team
Member
Author
|
/backport to stable33 |
CarlSchwan
approved these changes
Apr 15, 2026
Altahrim
reviewed
Apr 15, 2026
| $query = $this->connection->getQueryBuilder(); | ||
| $query->delete('mounts') | ||
| ->where($query->expr()->eq('mount_point', $query->createNamedParameter($mountPoint))); | ||
| ->where($query->expr()->eq('mount_point_hash', $query->createNamedParameter(hash('xxh128', $mountPoint)))); |
Collaborator
There was a problem hiding this comment.
We need to also keep filter on mount_point in case of (improbable) collision, no?
Member
Author
There was a problem hiding this comment.
afaik collisions are already impossible due other other unique contraints
salmart-dev
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #57760 for easier reviews.
Select by path hash instead of full path.