MAINT: Make test dir read-only#13872
Merged
drammock merged 10 commits intomne-tools:mainfrom Apr 28, 2026
Merged
Conversation
Member
Author
|
Failures probably related to GitHub having a bad day (took ages to access https://codeberg.org/nipy-data/nitest-freesurfer.git), I think this one is ready for review / marking for merge-when-green (and I'll tweak minimally as needed to get CIs green) |
* upstream/main: [pre-commit.ci] pre-commit autoupdate (mne-tools#13873)
drammock
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should avoid modifying
mne-testing-dataduring tests. Easiest way to enforce this is set the whole thingchmod -R a-wafter downloading.Any other repos that use
tools/github_actions_download.shwill need updates like mne-tools/mne-bids#1583, but I think this is actually good to force on them -- it's dangerous for one project to disrupt the state of the testing files (can lead to hard to track down bugs!).Locally with
pytestI'm already observing some failures after doing my ownchmod, but opening the PR here in true TDD fashion to make the CIs show it, too.