fix(ci): pass launch args to bind test, pin macOS WebKit to xlarge#3051
Merged
pavelfeldman merged 4 commits intomicrosoft:mainfrom Apr 29, 2026
Merged
fix(ci): pass launch args to bind test, pin macOS WebKit to xlarge#3051pavelfeldman merged 4 commits intomicrosoft:mainfrom
pavelfeldman merged 4 commits intomicrosoft:mainfrom
Conversation
Member
pavelfeldman
commented
Apr 29, 2026
pavelfeldman
commented
- test_bind_should_return_endpoint_and_allow_unbind launched the bundled chromium-headless-shell, which is absent on the Stable bots that only install chrome/msedge. Spread launch_arguments so the channel/headless settings reach BrowserType.launch. Added the sync mirror.
- macos-latest now resolves to macos-15-arm64 (free-tier standard), where WebKit child processes die during popup tests and cascade through the rest of the suite. Upstream microsoft/playwright moved cross-browser webkit jobs off macos-latest to macos-15-large/-xlarge for the same reason. Pin macOS+webkit slices to macos-15-xlarge via matrix exclude/include; other os/browser combos are unaffected.
- test_bind_should_return_endpoint_and_allow_unbind launched the bundled chromium-headless-shell, which is absent on the Stable bots that only install chrome/msedge. Spread launch_arguments so the channel/headless settings reach BrowserType.launch. Added the sync mirror. - macos-latest now resolves to macos-15-arm64 (free-tier standard), where WebKit child processes die during popup tests and cascade through the rest of the suite. Upstream microsoft/playwright moved cross-browser webkit jobs off macos-latest to macos-15-large/-xlarge for the same reason. Pin macOS+webkit slices to macos-15-xlarge via matrix exclude/include; other os/browser combos are unaffected. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
yury-s
approved these changes
Apr 29, 2026
…robe Two unrelated Windows-only failures on PR microsoft#3051: 1. test_connect_over_cdp_passing_header_works hung on Windows + Python 3.12/3.13: connect_over_cdp had no explicit timeout, the bogus ws://127.0.0.1/ws endpoint never speaks CDP, and the IOCP scheduler on 3.12+ kept the await past the 90s pytest timeout. Pass timeout=5000 so the Error rises promptly. Upstream's parallel TS test does the same with timeout: 100; 5000 leaves headroom for slow runners. 2. test_set_storage_state_should_apply_state_to_existing_context hung on Stable Edge (Windows) only. The two https://www.example.com navigations took the network path before page.route intercepted. Use http://example.com instead — same origin semantics for the localStorage assertion, no TLS setup. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Network.clearBrowserCache stalls on Edge stable, so set_storage_state (which clears cache + cookies in 'api' mode) hangs past the 90 s pytest timeout on Stable Windows msedge. Mirror the upstream skip: tests/library/browsercontext-storage-state.spec.ts:55 marks the equivalent JS scenario as fixme on msedge with the same reason. Reverts the http://example.com URL probe from the previous commit: the URL was never the issue. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
macos-13 hosted runners are scarce; the Conda Build job sat queued for the full PR cycle. macos-latest currently resolves to macos-15-arm64, which has plentiful capacity and runs the same conda-build flow. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.