fix: code quality issues#568
Merged
Roopan-Microsoft merged 2 commits intodevfrom Apr 29, 2026
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Roopan-Microsoft
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request includes several minor improvements and test code cleanups across the codebase. The main changes focus on improving test reliability, removing unnecessary code, and clarifying intent in asynchronous handlers.
Test code improvements:
test_count_documentsand ensured the mock was called correctly (src/tests/ContentProcessorAPI/libs/test_cosmos_db_helper.py).test_with_factoryby passing the class instead of a lambda (src/tests/ContentProcessorWorkflow/libs/application/test_application_context_di.py).handlerdecorator intest_rai_executor(src/tests/ContentProcessorWorkflow/steps/test_rai_executor.py).sitecustomizefrom the test configuration (src/tests/ContentProcessorWorkflow/conftest.py).Async handler clarity:
_, clarifying that the result is intentionally ignored (src/ContentProcessorWorkflow/src/services/content_process_service.py,src/ContentProcessorWorkflow/src/utils/http_request.py).Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information