MSC4163: Apply server ACLs to receipt and typing EDUs#783
Draft
MSC4163: Apply server ACLs to receipt and typing EDUs#783
Conversation
3 tasks
Comment on lines
+96
to
+98
| // Bob starts typing in both rooms | ||
| bob.SendTyping(t, roomID, true, 10000) | ||
| bob.SendTyping(t, sentinelRoom, true, 10000) |
Collaborator
There was a problem hiding this comment.
Feels like we can split the tests for PDU's vs EDU's
|
Hey, I'd be interested in taking over this PR to finish what has to be done. Is this ok for you @sandhose ? :) |
Collaborator
There was a problem hiding this comment.
Hey, I'd be interested in taking over this PR to finish what has to be done. Is this ok for you [...] ? :)
Sounds fine 👍 - I assume that means you creating a new PR.
(better to comment on the diff so we can thread the discussion)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synapse PR: element-hq/synapse#18475
For MSC4163