Conversation
GiovanniCanali
added
enhancement
dario-coscia
left a comment
dario-coscia
left a comment
There was a problem hiding this comment.
Two minor comments, otherwise all good.
PS. I thought we had burgers 🤯
| class BurgersProblem(TimeDependentProblem, SpatialProblem): | ||
| r""" | ||
| Implementation of the burgers problem in the spatial interval | ||
| :math:`[-1, 1]` and temporal interval :math:`[0, 1]`. |
There was a problem hiding this comment.
maybe let's add the equation here
There was a problem hiding this comment.
I have kept the same structure of other problems: the equation is described just in the corresponding class.
Maybe, we can add a more thorough description for all problems in the zoo (domain, boundary and initial conditions, pde, ...).
In such case, I will fix this for the BurgersProblem here and open a new PR for all other zoo members
| f"{len(spatial_d)}." | ||
| ) | ||
|
|
||
| # Ensure time is passed as input |
There was a problem hiding this comment.
I guess this types of check we already do in grad. Maybe we can use fast_grad afterwards to speed up a bit?
There was a problem hiding this comment.
Of course, grad already checks whether "t" is in the input labels. However, this error message is very explicit and I would keep it.
I can use fast_grad for the temporal derivative. Still, checks must be performed for the differential operators computed on spatial variables.
2 participants
Description
This PR fixes #792
Checklist