Skip to content

Add contact enpoints#105

Open
IgorDobryn wants to merge 4 commits intoMT-21830-sending-domainsfrom
MT-21830-contacts
Open

Add contact enpoints#105
IgorDobryn wants to merge 4 commits intoMT-21830-sending-domainsfrom
MT-21830-contacts

Conversation

@IgorDobryn
Copy link
Copy Markdown
Contributor

@IgorDobryn IgorDobryn commented Apr 28, 2026 •
edited
Loading

Motivation

Changes

  • POST /api/accounts/{account_id}/contacts/{contact_identifier}/events
  • POST /api/accounts/{account_id}/contacts/exports
  • GET /api/accounts/{account_id}/contacts/exports/{export_id}

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 516cee61-e36f-47a8-a2ee-3ad87eacda86

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch MT-21830-contacts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@IgorDobryn IgorDobryn changed the title Mt 21830 contacts Add contact enpoints Apr 28, 2026
@IgorDobryn IgorDobryn marked this pull request as ready for review April 28, 2026 13:56
@IgorDobryn IgorDobryn requested review from DagonWat and i7an April 28, 2026 13:56
i7an
i7an approved these changes Apr 29, 2026
View reviewed changes
Comment thread lib/mailtrap/contact_events_api.rb
# @return [ContactEvent] Created contact event object
# @!macro api_errors
# @raise [ArgumentError] If invalid options are provided
def create(contact_identifier, options)
Copy link
Copy Markdown
Contributor

@i7an i7an Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

base_create is not enough here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@i7an i7an i7an approved these changes

@DagonWat DagonWat Awaiting requested review from DagonWat

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IgorDobryn @i7an