Open
Conversation
- env_file triple absolute-path resolution (L12-17) - extra='forbid' + Field(...) required on kimi_apikey - ValidationError -> exit(78) + stderr diagnostic (L86-94) - @lru_cache on get_settings() - keyring references removed (grep clean) - cross-cwd .env reading verified (V7 APIKEY_HEAD=sk-9Bz) - V7/V8/V9 acceptance: rc=0/78/78 all green
Investigation finding (logs/forensics/): - feat(p2.3): APScheduler integration (2f99acc) did NOT introduce any tracked files under scheduler/ in this repository. - `git log --all -- scheduler/ acceptance_pathz_p1.py` -> empty. - `git ls-files -- scheduler/ acceptance_pathz_p1.py` -> empty. - Local work-tree artifacts (if any) were never indexed. Action: - Backlog P2.3 is re-opened; heartbeat loop in 1942684 remains the sole scheduler authority until P2.3 resumes. - This is an empty commit serving as an audit anchor so that the 4-commit p2.1-final seal has a visible revert record.
Physical verification (logs/forensics/):
[this session]
- memory_vec_bad_diff.patch : the original 'suspicious' diff
- bad_api_traceback.txt : get_embedding_dimension() -> 'BAD: 384' rc=0
- good_api_stdout.txt : get_sentence_embedding_dimension() -> 'GOOD: 384' rc=0
[earlier probes]
- diff_evidence.raw, introspect.stdout, print_jobs.stdout
Finding:
sentence-transformers==5.4.1 exposes BOTH
get_embedding_dimension() AND get_sentence_embedding_dimension()
Both return 384 on paraphrase-MiniLM-L6-v2 (the model configured in
this project; NOT all-MiniLM-L6-v2).
Decision: retain P1.2 canonical API `get_sentence_embedding_dimension()`
1. Documented in sbert.net across v1 -> v5.
2. v5.0/v5.4 release notes do NOT advertise get_embedding_dimension
as a rename/upgrade; it is an undocumented shorter alias.
3. Cross-version stability > 3-char shorter name.
Forensics retained as audit trail, not as behavioral change.
No code diff in memory_vec.py; see logs/forensics/ only.
Verifies 12 hard-evidence items for p2.1-final seal: - items 1-8 : Phase 1 (config + env + fail-fast) - items 9-10: git hygiene (tag + clean tree) - items 11-12: memory_vec API equivalence (forensics + byte-parity)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.