chore: Pass the VS Code (and extension) version to App Inspector#143
Merged
skyrpex merged 1 commit intointegrate-appinspector-uifrom Apr 23, 2026
Conversation
peter-smith-phd
changed the title
peter-smith-phd
requested review from
anisaoshafi,
localstack-bot,
skyrpex and
tiurin
as code owners
skyrpex
approved these changes
Apr 23, 2026
Contributor
skyrpex
left a comment
skyrpex
left a comment
There was a problem hiding this comment.
I'd suggest using undefined instead of null as it's a safer default (if for some reason the replacement of __APP_INSPECTOR_CONTEXT__ doesn't occur, the value will be undefined instead of null).
Otherwise, it looks good to me 👍🏻
| </head> | ||
| <body style="height: 100vh; margin: 0"> | ||
| <div id="root" style="height: 100%; display: flex; flex-direction: column"></div> | ||
| <script>window.__APP_INSPECTOR_CONTEXT__ = null;</script> |
Contributor
There was a problem hiding this comment.
Suggested change
| <script>window.__APP_INSPECTOR_CONTEXT__ = null;</script> | |
| <script>window.__APP_INSPECTOR_CONTEXT__ = undefined;</script> |
| source: "vscode"; | ||
| ideVersion: string; | ||
| extensionVersion: string; | ||
| } | null; |
Contributor
There was a problem hiding this comment.
Suggested change
| } | null; | |
| } | undefined; |
| ); | ||
| }) | ||
| .replace( | ||
| "window.__APP_INSPECTOR_CONTEXT__ = null;", |
Contributor
There was a problem hiding this comment.
Suggested change
| "window.__APP_INSPECTOR_CONTEXT__ = null;", | |
| "window.__APP_INSPECTOR_CONTEXT__ = undefined;", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Pass the VS Code version, and the LocalStack extension version into App Inspector. This will be used when App Inspector sends usage analytics to the backend.
Change Summary
__APP_INSPECTOR_CONTEXT__object into the App Inspector webview HTML containingsource: "vscode", the VS Code version, and the extension version.main.tsxand pass it toAppInspectorContextProviderasdeploymentContainer, with an"unknown"fallback when the placeholder is not substituted.Testing
Related
Part of DRG-472.
🤖 Generated with Claude Code