-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(tab-bar): add hideOnScroll for ionic theme #31085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f694300
feat(tab-bar): Adding hide-on-scroll prop for ionic theme
joselrio b7c8847
feat(tab-bar): Adding hide-on-scroll new prop sample
joselrio 265accb
chore(): add updated snapshots
Ionitron e373d50
fix(tab-bar): update position and animation based on requirements
joselrio 36ae3bc
feat(tab-bar): update to use new transition tokens
joselrio 499b921
Merge branch 'next' into ROU-12708
joselrio 86fd06c
Update package-lock.json
joselrio cacab99
fix(core): cast color name to a string in Sass interpolation to remov…
joselrio 2ca87d9
fix(tab-bar): update hide-on-scroll test sample
joselrio a11f04a
fix(core): run lint
joselrio e4f0395
fix(tab-bar): make usage of position mixin
joselrio 14a844d
Merge branch 'next' into ROU-12708
joselrio e252740
chore(): add updated snapshots
Ionitron b35b030
fix(tab-bar): fix ionic theme test
joselrio 737537d
chore(): add updated snapshots
Ionitron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+245 Bytes
(110%)
....ts-snapshots/tab-bar-expand-compact-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.03 KB
(130%)
...ts-snapshots/tab-bar-expand-compact-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+362 Bytes
(110%)
....ts-snapshots/tab-bar-expand-compact-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
81 changes: 81 additions & 0 deletions
81
core/src/components/tab-bar/test/hide-on-scroll/index.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en" dir="ltr" mode="ionic"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <title>Tab Bar - Hide on Scroll</title> | ||
| <meta | ||
| name="viewport" | ||
| content="width=device-width, initial-scale=1.0, minimum-scale=1.0, maximum-scale=1.0, user-scalable=no, viewport-fit=cover" | ||
| /> | ||
| <script src="../../../../../scripts/testing/scripts.js"></script> | ||
| <script nomodule src="../../../../../dist/ionic/ionic.js"></script> | ||
| <script type="module" src="../../../../../dist/ionic/ionic.esm.js"></script> | ||
| <link rel="stylesheet" href="../../../../../css/ionic.bundle.css" /> | ||
| <link rel="stylesheet" href="../../../../../scripts/testing/styles.css" /> | ||
| </head> | ||
|
|
||
| <body> | ||
| <ion-app> | ||
| <ion-tabs> | ||
| <div class="ion-page"> | ||
| <ion-content> | ||
| <div class="spacer"></div> | ||
| <div class="info"> | ||
| <p>Scroll down to hide the tab bar, scroll up to show it.</p> | ||
| <p><strong>Requirements:</strong></p> | ||
| <ul> | ||
| <li>Theme must be set to <code>ionic</code></li> | ||
| <li><code>expand</code> must be set to <code>compact</code></li> | ||
| <li>A sibling <code>ion-content</code> must exist for scroll detection</li> | ||
| </ul> | ||
| </div> | ||
| </ion-content> | ||
|
|
||
| <ion-footer> | ||
| <ion-tab-bar slot="bottom" hide-on-scroll="true" selected-tab="1" expand="compact"> | ||
| <ion-tab-button tab="1"> | ||
| <ion-icon name="home-outline"></ion-icon> | ||
| <ion-label>Home</ion-label> | ||
| </ion-tab-button> | ||
|
|
||
| <ion-tab-button tab="2"> | ||
| <ion-icon name="heart-outline"></ion-icon> | ||
| <ion-label>Favorites</ion-label> | ||
| </ion-tab-button> | ||
|
|
||
| <ion-tab-button tab="3"> | ||
| <ion-icon name="search-outline"></ion-icon> | ||
| <ion-label>Search</ion-label> | ||
| </ion-tab-button> | ||
|
|
||
| <ion-tab-button tab="4"> | ||
| <ion-icon name="settings-outline"></ion-icon> | ||
| <ion-label>Settings</ion-label> | ||
| </ion-tab-button> | ||
| </ion-tab-bar> | ||
| </ion-footer> | ||
| </div> | ||
| </ion-tabs> | ||
| </ion-app> | ||
|
|
||
| <style> | ||
| .spacer { | ||
| padding: 16px; | ||
| height: 2000px; | ||
| background: linear-gradient(to bottom, #e0f7fa, #80deea, #26c6da, #00acc1, #00838f); | ||
| } | ||
|
|
||
| .info { | ||
| position: fixed; | ||
| top: 30px; | ||
| left: 30px; | ||
| } | ||
|
|
||
| .info p { | ||
| margin-bottom: 12px; | ||
| font-size: 16px; | ||
| color: #333; | ||
| } | ||
| </style> | ||
| </body> | ||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.