feat: Add #[main] and #[dispatch] macros for type-safe guest entry points#1384
Open
jprendes wants to merge 2 commits intohyperlight-dev:mainfrom
Open
feat: Add #[main] and #[dispatch] macros for type-safe guest entry points#1384jprendes wants to merge 2 commits intohyperlight-dev:mainfrom
#[main] and #[dispatch] macros for type-safe guest entry points#1384jprendes wants to merge 2 commits intohyperlight-dev:mainfrom
Conversation
e102e16 to
65984e8
Compare
#[main] and #[dispatch] macros for type-safe guest entry points
#[main] and #[dispatch] macros for type-safe guest entry points#[main] and #[dispatch] macros for type-safe guest entry points
#[main] and #[dispatch] macros for type-safe guest entry points#[main] and #[dispatch] macros for type-safe guest entry points
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
65984e8 to
e0ebd45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces
#[main]and#[dispatch]attribute macros for defining guest entry points, replacing the previous pattern of manually exportingextern "C"functions with#[no_mangle].Changes
Make entry points optional
hyperlight_mainandguest_dispatch_functionare now optional using weak symbols with sensible defaults:hyperlight_maindefaults to a no-opguest_dispatch_functiondefaults to returning aGuestFunctionNotFounderrorAdd attribute macros
#[main]- Marks a function as the guest's initialization entry point#[dispatch]- Marks a function as the fallback handler for unregistered function callsExample
Before:
After:
Benefits
#[no_mangle]orextern "C"boilerplate