Add attention mask input support for flash backend#13479
Open
zhtmike wants to merge 2 commits intohuggingface:mainfrom
Open
Add attention mask input support for flash backend#13479zhtmike wants to merge 2 commits intohuggingface:mainfrom
zhtmike wants to merge 2 commits intohuggingface:mainfrom
Conversation
Contributor
Author
|
code snippet to show it works |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What does this PR do?
This PR adds support for attention mask input when using the attention backend with
set_attention_backend("flash"). With this change,QwenImagePipelinecan run with the flash backend w/ or w/oUlysses SP.For FlashAttention 2, it is not feasible to use
_wrapped_flash_attn_forwarddirectly when a mask is applied. To maintain compatibility with the current interface, we introduce an additional branch for FlashAttention to handle attention masks.I haven't tested with ring attention, so it is left as unimplemented.
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@sayakpaul
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.