Conversation
github-actions
bot
added
size/M
github-actions
bot
added
size/M
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
Left some comments. LMK if they are clear.
| ) | ||
| concurrency: | ||
| group: claude-review-${{ github.event.issue.number || github.event.pull_request.number }} | ||
| cancel-in-progress: true |
There was a problem hiding this comment.
Do we want to cancel a run that's in progress? Probably not because Claude can provide useful feedback on the first PR and that is also how we would often use it to do a review.
There was a problem hiding this comment.
agree with @sayakpaul here
e.g we may ask a question and then had another one before claude finish the first one ....
| DEFAULT_BRANCH: ${{ github.event.repository.default_branch }} | ||
| run: | | ||
| # Preserve main's CLAUDE.md before any fork checkout | ||
| cp CLAUDE.md /tmp/main-claude.md 2>/dev/null || touch /tmp/main-claude.md |
There was a problem hiding this comment.
Do we need a copy of everything under .ai from main because the review-rules.md references some files from the files present under .ai?
| "Bash(git commit*)", | ||
| "Bash(git push*)", |
There was a problem hiding this comment.
It should be able to commit specific rules to the rule file, actually:
1. NEVER modify, create, or delete files — unless the human comment contains verbatim:
COMMIT THIS (uppercase). If committing, only touch src/diffusers/ and .ai/.
How do we tackle that with this denial?
There was a problem hiding this comment.
I'm ok with keeping the claude CI read-only for now so we can get this PR merged quickly and get it into action:)
we can figure out how to allow it commit in safe way in a follow-up PR? @sayakpaul
yiyixuxu
left a comment
yiyixuxu
left a comment
There was a problem hiding this comment.
thanks for working on this @paulinebm!
i left one comment
| with: | ||
| anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }} | ||
| github_token: ${{ secrets.GITHUB_TOKEN }} | ||
| claude_args: '--model claude-opus-4-6' |
There was a problem hiding this comment.
| claude_args: '--model claude-opus-4-6' | |
| claude_args: '--model claude-opus-4-6 --append-system-prompt "${{ env.CLAUDE_SYSTEM_PROMPT }}"' |
I noticed that we moved the system prompt into the env but not used, is this intended (i.e. will the action automatically use it)? or should we use it here?
| "Bash(git commit*)", | ||
| "Bash(git push*)", |
There was a problem hiding this comment.
I'm ok with keeping the claude CI read-only for now so we can get this PR merged quickly and get it into action:)
we can figure out how to allow it commit in safe way in a follow-up PR? @sayakpaul
3 participants
cc @sayakpaul