Skip to content

[tests] add attention backend tests.#13174

Open
sayakpaul wants to merge 18 commits intomainfrom
attn-backend-tests
Open

[tests] add attention backend tests.#13174
sayakpaul wants to merge 18 commits intomainfrom
attn-backend-tests

Conversation

@sayakpaul
Copy link
Copy Markdown
Member

@sayakpaul sayakpaul commented Feb 23, 2026

What does this PR do?

Add attention backend tests.

@sayakpaul sayakpaul requested a review from DN6 February 23, 2026 06:01
@github-actions github-actions Bot added tests size/L PR with diff > 200 LOC labels Apr 17, 2026
DN6
DN6 reviewed Apr 23, 2026
View reviewed changes
Comment thread tests/models/testing_utils/attention.py Outdated
_BF16_REQUIRED_BACKENDS = {
AttentionBackendName._NATIVE_CUDNN,
AttentionBackendName.FLASH_HUB,
AttentionBackendName._FLASH_3_HUB,
Copy link
Copy Markdown
Collaborator

@DN6 DN6 Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include Sage as well?

Comment thread tests/models/testing_utils/attention.py Outdated
Comment thread tests/models/testing_utils/attention.py Outdated
Comment thread tests/models/testing_utils/attention.py Outdated
Comment thread tests/models/testing_utils/attention.py Outdated
Comment thread tests/models/testing_utils/attention.py Outdated
Comment thread tests/models/testing_utils/attention.py Outdated
@github-actions github-actions Bot added size/L PR with diff > 200 LOC and removed size/L PR with diff > 200 LOC labels Apr 23, 2026
@github-actions github-actions Bot added size/L PR with diff > 200 LOC and removed size/L PR with diff > 200 LOC labels Apr 23, 2026
@github-actions github-actions Bot added size/L PR with diff > 200 LOC and removed size/L PR with diff > 200 LOC labels Apr 23, 2026
@github-actions github-actions Bot added size/L PR with diff > 200 LOC and removed size/L PR with diff > 200 LOC labels Apr 23, 2026
@github-actions github-actions Bot added size/L PR with diff > 200 LOC and removed size/L PR with diff > 200 LOC labels Apr 23, 2026
@github-actions github-actions Bot added size/L PR with diff > 200 LOC and removed size/L PR with diff > 200 LOC labels Apr 23, 2026
@github-actions github-actions Bot added size/L PR with diff > 200 LOC and removed size/L PR with diff > 200 LOC labels Apr 23, 2026
@sayakpaul
Copy link
Copy Markdown
Member Author

sayakpaul commented Apr 23, 2026

@DN6, all your comments are addressed. LMK if anything is not addressed. I purposefully discarded SAGE to prefer the ones that I feel are more prevalent.

@github-actions github-actions Bot added size/L PR with diff > 200 LOC and removed size/L PR with diff > 200 LOC labels Apr 24, 2026
sayakpaul
sayakpaul commented Apr 24, 2026
View reviewed changes
Comment thread tests/models/testing_utils/attention.py
@sayakpaul
Apply suggestions from code review
a026a28 
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
@github-actions github-actions Bot added size/L PR with diff > 200 LOC and removed size/L PR with diff > 200 LOC labels Apr 24, 2026
@github-actions github-actions Bot added size/L PR with diff > 200 LOC and removed size/L PR with diff > 200 LOC labels Apr 24, 2026
@github-actions github-actions Bot added size/L PR with diff > 200 LOC and removed size/L PR with diff > 200 LOC labels Apr 24, 2026
@github-actions github-actions Bot added size/L PR with diff > 200 LOC and removed size/L PR with diff > 200 LOC labels Apr 25, 2026
@sayakpaul sayakpaul requested a review from DN6 April 25, 2026 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DN6 DN6 Awaiting requested review from DN6

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

size/L PR with diff > 200 LOC tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sayakpaul @DN6