Skip to content

Remove criteria F#1658

Closed
twof wants to merge 2 commits intographql:mainfrom
twof:patch-31
Closed

Remove criteria F#1658
twof wants to merge 2 commits intographql:mainfrom
twof:patch-31

Conversation

@twof
Copy link
Copy Markdown
Contributor

@twof twof commented Feb 17, 2025

Criteria F is a duplicate of Criteria C and is overly vague

@benjie
Copy link
Copy Markdown
Member

benjie commented Feb 17, 2025

F is not a duplicate of C, which is demonstrated by the evaluations for them differing - both proposal 2 and 4 fail criteria C (clarified in #1659), but for F proposal 2 is consistent because in a new schema with @strictNullability, Int always means "semantically non-nullable". Proposal 4 fails criteria F because it has two modes of operation on the same schema, and Int means essentially opposite things in these two modes: either nullable or non-nullable depending on the mode. Perhaps rather than removing this you can help reword it to make the difference clearer?

@twof twof closed this Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants