Conversation
Support Cache-Control, Content-Disposition, Content-Encoding, and Content-Language in AsyncAppendableObjectWriter (AAOW) by leveraging the Blob object attributes in gRPC conversions. Modified _BLOB_ATTR_TO_PROTO_FIELD in _grpc_conversions.py to include the new mappings. Added unit tests and updated system tests to verify the changes. Co-authored-by: nidhiii-27 <224584462+nidhiii-27@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Code Review
This pull request adds support for several blob metadata fields (cache_control, content_disposition, content_encoding, and content_language) in the gRPC conversion logic. It also includes corresponding updates to system tests and a new unit test to verify the conversion. I have no feedback to provide.
This change adds support for fixed-key metadata (Cache-Control, Content-Disposition, Content-Encoding, and Content-Language) in the
AsyncAppendableObjectWriter(AAOW). It achieves this by updating the_BLOB_ATTR_TO_PROTO_FIELDmapping ingoogle/cloud/storage/_grpc_conversions.py, which is used to convertBlobinstances to GCS V2 Object protos.New unit tests were added in
packages/google-cloud-storage/tests/unit/test__grpc_conversions.pyand the system testtest_write_from_blobinpackages/google-cloud-storage/tests/system/test_zonal.pywas updated to verify the functionality end-to-end.PR created automatically by Jules for task 17431433800443681077 started by @nidhiii-27