Skip to content

Add fixed-key metadata support in AAOW#16814

Closed
nidhiii-27 wants to merge 1 commit intomainfrom
feat-fixed-key-metadata-aaow-17431433800443681077
Closed

Add fixed-key metadata support in AAOW#16814
nidhiii-27 wants to merge 1 commit intomainfrom
feat-fixed-key-metadata-aaow-17431433800443681077

Conversation

@nidhiii-27
Copy link
Copy Markdown
Contributor

This change adds support for fixed-key metadata (Cache-Control, Content-Disposition, Content-Encoding, and Content-Language) in the AsyncAppendableObjectWriter (AAOW). It achieves this by updating the _BLOB_ATTR_TO_PROTO_FIELD mapping in google/cloud/storage/_grpc_conversions.py, which is used to convert Blob instances to GCS V2 Object protos.

New unit tests were added in packages/google-cloud-storage/tests/unit/test__grpc_conversions.py and the system test test_write_from_blob in packages/google-cloud-storage/tests/system/test_zonal.py was updated to verify the functionality end-to-end.


PR created automatically by Jules for task 17431433800443681077 started by @nidhiii-27

Support Cache-Control, Content-Disposition, Content-Encoding, and
Content-Language in AsyncAppendableObjectWriter (AAOW) by leveraging
the Blob object attributes in gRPC conversions.

Modified _BLOB_ATTR_TO_PROTO_FIELD in _grpc_conversions.py to include
the new mappings. Added unit tests and updated system tests to verify
the changes.

Co-authored-by: nidhiii-27 <224584462+nidhiii-27@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for several blob metadata fields (cache_control, content_disposition, content_encoding, and content_language) in the gRPC conversion logic. It also includes corresponding updates to system tests and a new unit test to verify the conversion. I have no feedback to provide.

@nidhiii-27 nidhiii-27 closed this Apr 27, 2026
@nidhiii-27 nidhiii-27 deleted the feat-fixed-key-metadata-aaow-17431433800443681077 branch April 27, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant