chore: remove product_documentation_override from librarian.yaml#16810
Open
jskeet wants to merge 3 commits intogoogleapis:mainfrom
Open
chore: remove product_documentation_override from librarian.yaml#16810jskeet wants to merge 3 commits intogoogleapis:mainfrom
jskeet wants to merge 3 commits intogoogleapis:mainfrom
Conversation
For handwritten libraries, this only affects .repo-metadata.json For generated libraries, the link may change, but should still be appropriate, and must exist so that the rst file is valid. Towards googleapis#5466
This was referenced Apr 27, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the product documentation URLs across multiple repository files, standardizing them to point to the base product pages rather than specific sub-pages. I have no feedback to provide as these changes are purely documentation updates.
Contributor
Author
|
Look like common protos is still broken. Not sure why that is yet - will look shortly. |
Contributor
Author
|
Given that the common protos aren't really a product, it would be better for us not to generate documentation which expects that it they are a product. We could conditionalize the template at https://raw.githubusercontent.com/googleapis/synthtool/refs/heads/master/synthtool/gcp/templates/python_mono_repo_library/README.rst, potentially. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For handwritten libraries, this only affects .repo-metadata.json
For generated libraries, the link may change, but should still be
appropriate, and must exist so that the rst file is valid.
Towards #5466