Skip to content

tests(bigframes): re-enable some tests blocking the doctest#16806

Merged
sycai merged 3 commits intomainfrom
main_chelsealin_doctets
Apr 27, 2026
Merged

tests(bigframes): re-enable some tests blocking the doctest#16806
sycai merged 3 commits intomainfrom
main_chelsealin_doctets

Conversation

@chelsea-lin
Copy link
Copy Markdown
Contributor

Fixes internal tests 506201379🦕

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates doctests and unit tests to align with changes in struct field ordering and simplifies JSON comparison logic using pd.testing.assert_series_equal. However, the removal of check_dtype=False in test_series.py may lead to test failures or flakiness if the dtypes from the BigQuery backend do not perfectly match the pandas defaults.

Comment thread packages/bigframes/tests/system/small/test_series.py Outdated
Comment thread packages/bigframes/tests/system/small/test_series.py Outdated
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_doctets branch from 6a475f4 to 95a2fba Compare April 24, 2026 22:30
@chalmerlowe
Copy link
Copy Markdown
Contributor

@chelsea-lin

These appear in both Kokoro System and Kokoro Prerelease Tests:

FAILED tests/system/small/test_series.py::test_divmods_series[rdivmod-int64_col-int64_col]
FAILED tests/system/small/test_series.py::test_divmods_scalars[divmod--1000-int64_col]
FAILED tests/system/small/test_series.py::test_divmods_series[divmod-int64_col-int64_col]
FAILED tests/system/small/test_series.py::test_divmods_scalars[divmod-678-int64_col]
FAILED tests/system/small/test_series.py::test_divmods_scalars[rdivmod--1000-int64_col]
FAILED tests/system/small/test_series.py::test_divmods_scalars[rdivmod-678-int64_col]

@chelsea-lin chelsea-lin force-pushed the main_chelsealin_doctets branch from 95a2fba to 0969bec Compare April 27, 2026 19:54
@chelsea-lin chelsea-lin marked this pull request as ready for review April 27, 2026 21:20
@chelsea-lin chelsea-lin requested review from a team as code owners April 27, 2026 21:20
@chelsea-lin chelsea-lin requested review from chalmerlowe and sycai and removed request for a team April 27, 2026 21:21
@chelsea-lin chelsea-lin added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 27, 2026
@sycai sycai merged commit 6224fb6 into main Apr 27, 2026
30 checks passed
@sycai sycai deleted the main_chelsealin_doctets branch April 27, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kokoro:run Add this label to force Kokoro to re-run the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants