chore: remove issue_tracker_override from librarian.yaml#16792
chore: remove issue_tracker_override from librarian.yaml#16792jskeet wants to merge 2 commits intogoogleapis:mainfrom
Conversation
|
@daniel-sanche It looks like this is only used in .repo-metadata.json, not in published documentation, so I think this should be safe to simply merge. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request primarily updates or removes issue tracker metadata across numerous packages in librarian.yaml and .repo-metadata.json files. However, it also includes a refactor of the system test execution logic in packages/google-cloud-spanner/noxfile.py. Feedback indicates that this refactor introduces several regressions, such as omitting the necessary asyncio_mode configuration, merging sync and async test runs which may cause side effects, and removing sanity checks that ensure the Nox session skips gracefully when tests are missing.
jskeet
force-pushed
the
remove-issue-tracker-override
branch
from
57e4c6b to
c95e291
Compare
|
Closing as this will be regenerated |
1 participant
Towards googleapis/librarian#5465