feat(bigframes): implement ai.similarity#16771
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the similarity function to the BigQuery AI module, enabling cosine similarity calculations between strings or series using Vertex AI models. The implementation includes the necessary operation definitions, compiler registrations for Ibis and SQLGlot, and comprehensive system and unit tests. Review feedback identified a consistent typo in the model name 'embedding-gemma-300m' within the documentation and test cases.
sycai
requested review from
TrevorBergeron and
chelsea-lin
and removed request for
mpovoa
sycai
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
TrevorBergeron
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes b/497837587