feat: [pubsub] add W3C Baggage support #8048
Open
aris-cub wants to merge 4 commits intogoogleapis:mainfrom
Open
feat: [pubsub] add W3C Baggage support #8048aris-cub wants to merge 4 commits intogoogleapis:mainfrom
aris-cub wants to merge 4 commits intogoogleapis:mainfrom
Conversation
The telemetry-tracing module only propagates W3C Trace Context (traceparent/tracestate) but not W3C Baggage. This prevents downstream consumers from receiving arbitrary key-value metadata through Pub/Sub messages, which is needed for use cases like message routing and queue splitting. Uses CompositePropagator to combine W3CTraceContextPropagator and W3CBaggagePropagator. No new dependencies required — both are already in @opentelemetry/core.
- Add baggage key to `containsSpanContext` - Use `context.with()` in injection test
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
Hi @shivanee-p and @feywind , could you take a look at this when you get a chance? This adds W3C Baggage propagation support for Pub/Sub (related to #8046). I'm happy to address any feedback you might have! |
retain propagation context to prevent dropping baggage - Store context on message and activate for user callbacks. - Rename containsSpanContext to containsPropagationContext. - Update copyright year.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add W3C Baggage support
Fixes #8046