ignore stale merged/closed PRs for reused branch names

[skarim]

Ignore stale merged/closed PRs for reused branch names

When a branch name previously used in a merged or closed PR is reused in a new stack, syncStackPRs would adopt the old PR and incorrectly mark the branch as "MERGED". This caused gh stack view to show the wrong status, gh stack submit to skip PR creation, and gh stack push to skip the branch entirely.

Root cause: syncStackPRs called FindAnyPRForBranch (returns the most recent PR regardless of state) for every branch, including ones with no locally tracked PR. A reused branch name would pick up the old merged/closed PR from a previous stack.

Fix: Rewrite syncStackPRs with two sync modes:

1. Remote stack exists (s.ID set) — stack API is source of truth:

• Fetches the remote stack's PR list via ListStacks, looks up each PR by number, and matches to local branches by head ref name.
• PRs stay associated regardless of state (open, closed, merged) — the stack API owns the relationship.
• Falls back to local discovery if the API fails or the stack isn't found.

2. No remote stack — local branch-name discovery:

• Merged PR → skip. The merged state is final and doesn't need refreshing.
• Tracked PR (not merged) → refresh via FindPRByNumber. If the PR was closed (not merged), clear the association and fall through to open-PR discovery.
• No tracked PR → use FindPRForBranch (OPEN state only), preventing adoption of stale merged/closed PRs.

Additional fixes:

• TUI data loader (data.go): FindPRDetailsForBranch also returned stale merged PRs via last: 1. Added a filter so PR details are only shown if the PR matches the tracked number or is OPEN.
• FindPRByNumber (github.go): Now returns nil for zero-value GraphQL responses.
• Test mocks: Several existing tests were missing GitHubClientOverride and silently hitting the real API. Fixed with proper mocks. Updated mock functions from FindAnyPRForBranchFn to FindPRByNumberFn where branches have tracked PRs.

---

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

[Copilot]

Pull request overview

This PR hardens PR metadata discovery so reused branch names don’t accidentally pick up stale merged/closed PRs, and it updates sync logic to prefer authoritative sources (remote stack API when available, otherwise OPEN-only branch discovery).

Changes:

• Update TUI branch node loading to only adopt PR details when the PR is tracked for that branch or is currently OPEN.
• Rework syncStackPRs to (a) use the stack API as source of truth when Stack.ID is set and (b) otherwise refresh tracked PRs by number and only adopt OPEN PRs by branch name.
• Add/adjust tests across TUI + cmd packages and refine GitHub client behavior for “PR not found”.

Show a summary per file

File	Description
internal/tui/stackview/data.go	Filter adopted PR details to avoid showing stale merged/closed PRs for reused branch names.
internal/tui/stackview/data_test.go	Add coverage for ignoring stale merged PR details and still showing tracked merged + OPEN PRs.
internal/github/github.go	Make FindPRByNumber return nil for “not found” results.
cmd/utils.go	Rework PR sync: remote stack API path + local OPEN-only adoption path.
cmd/utils_test.go	Add extensive tests for new PR sync behavior (tracked/untracked, merged/closed, remote stack).
cmd/view_test.go	Update mocks to use PR-by-number lookups consistent with new sync behavior.
cmd/submit_test.go	Update mocks/expectations for new sync behavior; add a missing pipe close.
cmd/merge_test.go	Ensure merge tests provide a GitHub client override since merge now always syncs PR state.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 8/8 changed files
• Comments generated: 1

[Lukeghenco]

Should we return if this evaluates to falsy too?

[skarim]

if syncStackPRsFromRemote returns falsy it likely means the stack was deleted on remote, so we need to fallback to the loop below.

[Lukeghenco]

This code seems correct based on my limited knowledge of some of the API callers.