Skip to content

C++: Update expected test results after extractor changes#21409

Open
jketema wants to merge 1 commit intogithub:mainfrom
jketema:jketema/softfloat
Open

C++: Update expected test results after extractor changes#21409
jketema wants to merge 1 commit intogithub:mainfrom
jketema:jketema/softfloat

Conversation

@jketema
Copy link
Copy Markdown
Contributor

@jketema jketema commented Mar 4, 2026

No description provided.

@jketema jketema added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Mar 4, 2026
@github-actions github-actions Bot added the C++ label Mar 4, 2026
@jketema jketema force-pushed the jketema/softfloat branch 3 times, most recently from 296262e to 092b8c9 Compare April 21, 2026 11:20
@jketema jketema force-pushed the jketema/softfloat branch from 092b8c9 to f50bbdb Compare April 23, 2026 08:14
@jketema jketema added the no-change-note-required This PR does not need a change note label Apr 24, 2026
@jketema jketema marked this pull request as ready for review April 24, 2026 14:20
@jketema jketema requested a review from a team as a code owner April 24, 2026 14:20
Copilot AI review requested due to automatic review settings April 24, 2026 14:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates C++ QL test .expected files to match new extractor output formatting, primarily around floating-point literal rendering and resulting IR/AST test baselines.

Changes:

  • Normalize floating-point literal formatting in query-test and library-test expected outputs (e.g., scientific notation and trimmed decimal expansions).
  • Update IR/AST printed expectations to reflect the new canonical literal formatting.
  • Adjust guard/rangeanalysis expected outputs where numeric literal string forms changed.
Show a summary per file
File Description
cpp/ql/test/query-tests/Likely Bugs/Underspecified Functions/MistypedFunctionArguments.expected Updates expected argument-literal spellings (e.g., 2.5E9, 3.5E15) to match extractor output.
cpp/ql/test/library-tests/rangeanalysis/SimpleRangeAnalysis/nrOfBounds.expected Replaces long floating expansions with shortened canonical forms across many rows.
cpp/ql/test/library-tests/ir/ir/raw_ir.expected Updates IR constants (e.g., 2.200000...2.2, 2.299999...2.3) and corresponding formatting.
cpp/ql/test/library-tests/ir/ir/aliased_ir.expected Mirrors raw IR expected updates for constants/formatting in the aliased IR output.
cpp/ql/test/library-tests/ir/ir/PrintAST.expected Updates printed AST literal values to match new canonical formatting.
cpp/ql/test/library-tests/controlflow/guards/GuardsEnsure.expected Updates expected numeric literal rendering in guard outputs (e.g., ...e-071.0E-6).
cpp/ql/test/library-tests/controlflow/guards/GuardsCompare.expected Updates guard comparison text expectations to use the new literal formatting.
cpp/ql/test/library-tests/builtins/complex/builtin.expected Updates expected builtin complex literal component formatting (trimmed float/double strings).

Copilot's findings

  • Files reviewed: 8/8 changed files
  • Comments generated: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants