C++: Update expected test results after extractor changes#21409
Open
jketema wants to merge 1 commit intogithub:mainfrom
Open
C++: Update expected test results after extractor changes#21409jketema wants to merge 1 commit intogithub:mainfrom
jketema wants to merge 1 commit intogithub:mainfrom
Conversation
296262e to
092b8c9
Compare
092b8c9 to
f50bbdb
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates C++ QL test .expected files to match new extractor output formatting, primarily around floating-point literal rendering and resulting IR/AST test baselines.
Changes:
- Normalize floating-point literal formatting in query-test and library-test expected outputs (e.g., scientific notation and trimmed decimal expansions).
- Update IR/AST printed expectations to reflect the new canonical literal formatting.
- Adjust guard/rangeanalysis expected outputs where numeric literal string forms changed.
Show a summary per file
| File | Description |
|---|---|
| cpp/ql/test/query-tests/Likely Bugs/Underspecified Functions/MistypedFunctionArguments.expected | Updates expected argument-literal spellings (e.g., 2.5E9, 3.5E15) to match extractor output. |
| cpp/ql/test/library-tests/rangeanalysis/SimpleRangeAnalysis/nrOfBounds.expected | Replaces long floating expansions with shortened canonical forms across many rows. |
| cpp/ql/test/library-tests/ir/ir/raw_ir.expected | Updates IR constants (e.g., 2.200000... → 2.2, 2.299999... → 2.3) and corresponding formatting. |
| cpp/ql/test/library-tests/ir/ir/aliased_ir.expected | Mirrors raw IR expected updates for constants/formatting in the aliased IR output. |
| cpp/ql/test/library-tests/ir/ir/PrintAST.expected | Updates printed AST literal values to match new canonical formatting. |
| cpp/ql/test/library-tests/controlflow/guards/GuardsEnsure.expected | Updates expected numeric literal rendering in guard outputs (e.g., ...e-07 → 1.0E-6). |
| cpp/ql/test/library-tests/controlflow/guards/GuardsCompare.expected | Updates guard comparison text expectations to use the new literal formatting. |
| cpp/ql/test/library-tests/builtins/complex/builtin.expected | Updates expected builtin complex literal component formatting (trimmed float/double strings). |
Copilot's findings
- Files reviewed: 8/8 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.