fix(cli): Suppress false compiler errors in test summaries#387
Merged
cameroncooke merged 2 commits intomainfrom May 1, 2026
Merged
Conversation
Tighten xcodebuild diagnostic detection so Objective-C selector labels in NSError dump lines are not treated as compiler errors. Align CLI streaming finalization so buffered compiler diagnostics do not print after a successful summary. Add compiler-error snapshot coverage for simulator, device, and macOS build, build-and-run, and test flows across CLI, MCP, and JSON output. Fixes #383 Co-Authored-By: Codex <noreply@openai.com>
commit: |
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
Trigger compiler-error snapshot cases with a guarded Swift compile flag instead of patching example project files during test execution. This keeps snapshot tests deterministic and avoids leaving tracked source files corrupted if a run is interrupted. Refs GH-387 Co-Authored-By: Codex <codex@openai.com>
cameroncooke
deleted the
cameroncooke/fix/xcodebuild-compiler-error-snapshots
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix false compiler-error sections in CLI test summaries when xcodebuild emits noisy NSError dump lines.
The parser previously treated embedded Objective-C selector labels such as
pid:error:,as build diagnostics, which could turn simulator launch-service noise into a buffered compiler error. The CLI renderer could then flush that buffered error after a successful test summary, producing contradictory output.This tightens build-error classification, aligns streaming finalization with successful summaries, and adds compiler-error snapshot coverage for simulator, device, and macOS build-style flows across CLI, MCP, and JSON output. The snapshot tests temporarily patch fixture source files and restore the original contents in
finally; snapshot execution is configured serially viavitest.snapshot.config.ts.Fixes #383