Conversation
Advance the binary-compatibility baseline from the old 0.4.0 entry-point
to the current stable release (1.1.1), so the SDK's package-validation
check now guards against accidentally removing or changing any public API
that exists in the version most users have installed.
Regenerate CompatibilitySuppressions.xml against the new baseline:
- Remove three now-unnecessary suppressions for F# infrastructure Bind/For
overloads (they already exist in 1.1.1 so no delta to suppress).
- Retain the single intentional suppression for Async.bind: the old
incorrect signature (Async<'T> -> Async<'U>) is present in 1.1.1 but
has been fixed in the Unreleased version to the correct ('T -> Async<'U>)
form.
Build: dotnet build src/FSharp.Control.TaskSeq.sln -c Release -> 0 errors
Tests: 5251 passed, 2 skipped, 0 failed
Formatting: dotnet fantomas . --check -> clean
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
24 tasks
dsyme
approved these changes
May 1, 2026
dsyme
deleted the
repo-assist/eng-package-validation-baseline-20260501-c8051c00776a335d
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist, an AI assistant.
Summary
Advances the
PackageValidationBaselineVersionin the library.fsprojfrom the old0.4.0entry-point to the current stable release1.1.1.The SDK's [package validation]((learn.microsoft.com/redacted) feature compares the package produced by the current build against the specified baseline version downloaded from NuGet. With the baseline set to
0.4.0, the check was comparing against a version that is nearly two major versions old, meaning many legitimate API additions were flagged as "new" and suppressions accumulated for differences that are no longer meaningful. With1.1.1as the baseline, the check guards against accidentally removing or changing any public API that exists in the version most users currently have installed.Changes
FSharp.Control.TaskSeq.fsprojPackageValidationBaselineVersion0.4.0→1.1.1; updated commentCompatibilitySuppressions.xmlrelease-notes.txtUnreleasedSuppression file cleanup
Regenerating against
1.1.1removed three now-unnecessary suppressions:LowPriority.TaskSeqBuilder#Bind``5— these F# infrastructure overloads already exist in the published1.1.1package, so there is no delta to suppress.LowPriority.TaskSeqBuilder#Bind$W``5— same.TaskExtensions.TaskBuilder#For``2— same.One suppression is retained intentionally:
Async.bindwith the old incorrect signature(Async<'T> -> Async<'U>)— this signature is present in1.1.1but has been fixed in theUnreleasedversion to the correct('T -> Async<'U>)form, a deliberate and documented breaking change for a broken API.Test Status
dotnet build src/FSharp.Control.TaskSeq.sln -c Release— 0 warnings, 0 errorsdotnet test ... -c Release— 5251 passed, 2 skipped, 0 faileddotnet fantomas . --check— formatting clean