Conversation
50+ test files already use the plural 'SideEffects' module name. Concat.Tests.fs, Delay.Tests.fs, and Item.Tests.fs were the only outliers still using the singular form 'SideEffect'. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Apr 26, 2026
…425-edfad27e8fbe8b06
…425-edfad27e8fbe8b06
dsyme
approved these changes
May 1, 2026
…425-edfad27e8fbe8b06
…425-edfad27e8fbe8b06
…425-edfad27e8fbe8b06
…425-edfad27e8fbe8b06
dsyme
deleted the
repo-assist/improve-sideeffects-naming-20260425-edfad27e8fbe8b06
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist, an AI assistant.
Summary
Three test files used
module SideEffect =(singular) while the rest of the test suite — over 50 files — consistently usesmodule SideEffects =(plural). This PR fixes the naming inconsistency.Files changed:
TaskSeq.Concat.Tests.fs:module SideEffect→module SideEffectsTaskSeq.Delay.Tests.fs:module SideEffect→module SideEffectsTaskSeq.Item.Tests.fs:module SideEffect→module SideEffectsNo tests were added or removed; this is a pure rename for consistency.
Test Status
dotnet build src/FSharp.Control.TaskSeq.sln -c Release— succeeded (0 warnings, 0 errors)dotnet fantomas --check— clean