Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions scripts/gha/print_matrix_configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,19 +174,19 @@
TEST_DEVICES = {
"android_target": [
{"type": "ftl", "device": "model=blueline,version=28"}, # Pixel 3
{"type": "ftl", "device": "model=gts3lltevzw,version=28"}, # Galaxy Tab S3
{"type": "ftl", "device": "model=gts8wifi,version=34"}, # Galaxy Tab S8
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The android_target group appears to be intended for testing on API level 28 (Android 9), as seen with the other devices in this list (Pixel 3 and AQUOS sense2). Replacing the Galaxy Tab S3 with a Galaxy Tab S8 running API level 34 introduces an inconsistency in the API coverage for this group. If the goal is to maintain a consistent baseline for 'target' devices, consider using a device model that supports API level 28 in Firebase Test Lab.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I still want a samsung and a table this is really the only option.

{"type": "ftl", "device": "model=SH-01L,version=28"}, # AQUOS sense2 SH-01L
],
"android_latest": [
{"type": "ftl", "device": "model=oriole,version=33"}, # Pixel 6
{"type": "ftl", "device": "model=panther,version=33"}, # Pixel 7
{"type": "ftl", "device": "model=lynx,version=33"}, # Pixel 7a
{"type": "ftl", "device": "model=cheetah,version=33"}, # Pixel 7 Pro
{"type": "ftl", "device": "model=felix,version=33"}, # Pixel Fold
{"type": "ftl", "device": "model=tokay,version=36"}, # Pixel 9
{"type": "ftl", "device": "model=frankel,version=36"}, # Pixel 10
{"type": "ftl", "device": "model=stallion,version=36"}, # Pixel 10a
{"type": "ftl", "device": "model=mustang,version=36"}, # Pixel 10 Pro XL
{"type": "ftl", "device": "model=rango,version=36"}, # Pixel 10 Pro Fold
Comment on lines +181 to +185
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The android_latest configuration contains several discrepancies:

  • API Version Inconsistency: There is a mix of API level 36 and API level 34 (and 33 for the Pixel Tablet) within the same group.
  • Invalid API Level: API level 36 is not currently a standard Android release (Android 15 is API 35).
  • Unreleased Hardware: Models such as frankel (Pixel 10) and rango (Pixel 10 Pro Fold) refer to unreleased devices that are likely not yet available in Firebase Test Lab.

It is recommended to use a consistent, supported API level (e.g., 34 or 35) and valid device models to ensure the stability of the integration tests.

{"type": "ftl", "device": "model=tangorpro,version=33"}, # Pixel Tablet
{"type": "ftl", "device": "model=gts8uwifi,version=33"}, # Galaxy Tab S8 Ultra
{"type": "ftl", "device": "model=b0q,version=33"}, # Galaxy S22 Ultra
{"type": "ftl", "device": "model=b4q,version=33"}, # Galaxy Z Flip4
{"type": "ftl", "device": "model=gts9wifi,version=34"}, # Galaxy Tab S9
{"type": "ftl", "device": "model=pa3q,version=36"}, # Galaxy S25 Ultra
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The model pa3q (Galaxy S25 Ultra) and the specified version=36 are inconsistent with other devices in this group (e.g., Galaxy Tab S9 and Z Flip6 use version 34). Additionally, this hardware and API level are likely not yet available in Firebase Test Lab. Please use a consistent and supported configuration.

{"type": "ftl", "device": "model=b6q,version=34"}, # Galaxy Z Flip6
],
"emulator_ftl_target": [
{"type": "ftl", "device": "model=Pixel2,version=28"},
Expand Down
Loading