-
Notifications
You must be signed in to change notification settings - Fork 136
Update test devices #1850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test devices #1850
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -174,19 +174,19 @@ | |
| TEST_DEVICES = { | ||
| "android_target": [ | ||
| {"type": "ftl", "device": "model=blueline,version=28"}, # Pixel 3 | ||
| {"type": "ftl", "device": "model=gts3lltevzw,version=28"}, # Galaxy Tab S3 | ||
| {"type": "ftl", "device": "model=gts8wifi,version=34"}, # Galaxy Tab S8 | ||
| {"type": "ftl", "device": "model=SH-01L,version=28"}, # AQUOS sense2 SH-01L | ||
| ], | ||
| "android_latest": [ | ||
| {"type": "ftl", "device": "model=oriole,version=33"}, # Pixel 6 | ||
| {"type": "ftl", "device": "model=panther,version=33"}, # Pixel 7 | ||
| {"type": "ftl", "device": "model=lynx,version=33"}, # Pixel 7a | ||
| {"type": "ftl", "device": "model=cheetah,version=33"}, # Pixel 7 Pro | ||
| {"type": "ftl", "device": "model=felix,version=33"}, # Pixel Fold | ||
| {"type": "ftl", "device": "model=tokay,version=36"}, # Pixel 9 | ||
| {"type": "ftl", "device": "model=frankel,version=36"}, # Pixel 10 | ||
| {"type": "ftl", "device": "model=stallion,version=36"}, # Pixel 10a | ||
| {"type": "ftl", "device": "model=mustang,version=36"}, # Pixel 10 Pro XL | ||
| {"type": "ftl", "device": "model=rango,version=36"}, # Pixel 10 Pro Fold | ||
|
Comment on lines
+181
to
+185
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The
It is recommended to use a consistent, supported API level (e.g., 34 or 35) and valid device models to ensure the stability of the integration tests. |
||
| {"type": "ftl", "device": "model=tangorpro,version=33"}, # Pixel Tablet | ||
| {"type": "ftl", "device": "model=gts8uwifi,version=33"}, # Galaxy Tab S8 Ultra | ||
| {"type": "ftl", "device": "model=b0q,version=33"}, # Galaxy S22 Ultra | ||
| {"type": "ftl", "device": "model=b4q,version=33"}, # Galaxy Z Flip4 | ||
| {"type": "ftl", "device": "model=gts9wifi,version=34"}, # Galaxy Tab S9 | ||
| {"type": "ftl", "device": "model=pa3q,version=36"}, # Galaxy S25 Ultra | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The model |
||
| {"type": "ftl", "device": "model=b6q,version=34"}, # Galaxy Z Flip6 | ||
| ], | ||
| "emulator_ftl_target": [ | ||
| {"type": "ftl", "device": "model=Pixel2,version=28"}, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
android_targetgroup appears to be intended for testing on API level 28 (Android 9), as seen with the other devices in this list (Pixel 3 and AQUOS sense2). Replacing the Galaxy Tab S3 with a Galaxy Tab S8 running API level 34 introduces an inconsistency in the API coverage for this group. If the goal is to maintain a consistent baseline for 'target' devices, consider using a device model that supports API level 28 in Firebase Test Lab.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I still want a samsung and a table this is really the only option.