fix(eslint-plugin-react-hooks): fix configs.flat properties typed as undefined in strict mode#36273
Conversation
…ble in strict TypeScript
|
Hi @abhishekayu! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Fixes #36016
Summary
When using
eslint-plugin-react-hookswith TypeScript strict mode, accessingconfigs.flat.recommendedineslint.config.tsthrows:The issue is that
configs.flatwas initialized as an empty object{}with a type cast. TypeScript doesn't know the properties exist untilObject.assignruns later, so it treats them as possiblyundefinedin strict mode.Two small changes to fix this:
null as unknown as {...}instead of{} as {...}for the initial declarationObject.assign(configs.flat, {...})with a direct assignmentconfigs.flat = {...}Runtime behavior is identical - only the types change.
How did you test this change?
Checked that
configs.flat.recommendedandconfigs.flat['recommended-latest']are no longer inferred asT | undefinedin strict mode.This now works without needing
!: